Reset plasma id at every call of Init#963
Merged
AlexanderSinn merged 1 commit intoHi-PACE:developmentfrom May 31, 2023
Merged
Conversation
MaxThevenet
added
bug
MaxThevenet
changed the title
Member
Author
|
Confirmed, this fixes the issue. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue that large simulations (counting
nx*ny*nt) run out of id. Another option would be to always useamrex::Longin this function for ID handling. Preliminary tests seem to show that both fix the problem (we'll know when Jupyter @ JSC is back). This one is a bit simpler.