Skip to content

electron: Library and moveGame fixes. - #348

Merged
adityaruplaha merged 4 commits into
mainfrom
fix_installing_statuses
May 8, 2021
Merged

adityaruplaha merged 4 commits into
mainfrom
fix_installing_statuses

Conversation

@flavioislima

@flavioislima flavioislima commented May 8, 2021 •

Copy link
Copy Markdown
Member

Miscellaneous fixes.

@adityaruplaha's note:
Moving games between different different devices can't be acheived using renameSync, this PR reverts to using shell mv. See nodejs/node#19077 for details.

@flavioislima
flavioislima requested a review from adityaruplaha May 8, 2021 09:28

@adityaruplaha adityaruplaha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

Comment thread electron/games.ts Resolved
Comment thread src/state/GlobalState.tsx Resolved
Comment thread src/state/GlobalState.tsx Resolved

@adityaruplaha adityaruplaha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@adityaruplaha adityaruplaha changed the title Fix Install status and Fix Move Games feature electron: Library and moveGame fixes. May 8, 2021
@adityaruplaha
adityaruplaha merged commit 5ae9e98 into main May 8, 2021
@adityaruplaha
adityaruplaha deleted the fix_installing_statuses branch May 8, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants