Skip to content

Improved atCommand(mobinfo)#3328

Merged
MishimaHaruna merged 1 commit intoHerculesWS:masterfrom
Venseer:improved-atcommand-mobinfo
Oct 31, 2024
Merged

Improved atCommand(mobinfo)#3328
MishimaHaruna merged 1 commit intoHerculesWS:masterfrom
Venseer:improved-atcommand-mobinfo

Conversation

@Venseer
Copy link
Copy Markdown
Contributor

@Venseer Venseer commented Oct 29, 2024

Pull Request Prelude

Changes Proposed

Change mobinfo atcommand. Drop list now users item links.

20241029192904683 - CommonRigidAmurratsnake

Copy link
Copy Markdown
Member

@MishimaHaruna MishimaHaruna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few suggestions for improvements, please have a look

@Venseer Venseer force-pushed the improved-atcommand-mobinfo branch from e1b69dd to 4b32685 Compare October 31, 2024 20:05
@Venseer
Copy link
Copy Markdown
Contributor Author

Venseer commented Oct 31, 2024

Made some adjustments regarding strbuffer initialization.
New: Added MVP drops item link too.

20241031170441664 - EasyInfantileGonolek

@Venseer Venseer force-pushed the improved-atcommand-mobinfo branch 3 times, most recently from 1931af5 to 45004f9 Compare October 31, 2024 20:16
@MishimaHaruna MishimaHaruna added this to the Release v2024.10 milestone Oct 31, 2024
@MishimaHaruna MishimaHaruna changed the base branch from stable to master October 31, 2024 22:19
@MishimaHaruna MishimaHaruna merged commit 2615a40 into HerculesWS:master Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants