Validate length of configuration names from add*Conf HPM commands#3324
Merged
MishimaHaruna merged 1 commit intoHerculesWS:masterfrom Sep 29, 2024
Merged
Conversation
Providing a too long name/path would silently fail otherwise.
ghost
approved these changes
Sep 22, 2024
4144
approved these changes
Sep 23, 2024
skyleo
approved these changes
Sep 24, 2024
MishimaHaruna
approved these changes
Sep 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Adds a validation when configuration registered by HPM are longer than the supported size.
Today it would silently fail because the registered key is shorter than the actual name, it would not work but also not alert because it simply didn't find and the defaults for
add*Confmacros is to make them not required.With this change, users would be informed that this configuration won't work so they can provide a shorter name or increase the define.
Issues addressed: None, I think