Add *getunitparam to obtain values set via unit_parameters_db.conf in scripts#3323
Merged
MishimaHaruna merged 1 commit intoHerculesWS:masterfrom Sep 29, 2024
Merged
Conversation
guilherme-gm
requested changes
Sep 21, 2024
Member
guilherme-gm
left a comment
guilherme-gm
left a comment
There was a problem hiding this comment.
other than that small detail, looks good to me
skyleo
force-pushed
the
add-getunitparam-scriptcmd
branch
from
285b528 to
7b6437f
Compare
guilherme-gm
approved these changes
Sep 21, 2024
MishimaHaruna
requested changes
Sep 29, 2024
skyleo
force-pushed
the
add-getunitparam-scriptcmd
branch
from
7b6437f to
1adb7c6
Compare
MishimaHaruna
approved these changes
Sep 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Add a new script command named
getunitparamto obtain the values set via unit_parameters_db.conf which used to be obtainable via getbattleflag(...)In relation to: #3214
NOTE: The deprecation warning of the deprecated keys for the battle flags, is not shown when using getbattleflag(..), but zero (or the default value) is silently returned instead.
Issues addressed: None