Stop sending standalone players to API server#3314
Merged
MishimaHaruna merged 4 commits intoHerculesWS:masterfrom Aug 31, 2024
Merged
Stop sending standalone players to API server#3314MishimaHaruna merged 4 commits intoHerculesWS:masterfrom
MishimaHaruna merged 4 commits intoHerculesWS:masterfrom
Conversation
guilherme-gm
force-pushed
the
api-autotrade
branch
from
9f414cf to
e2a0018
Compare
Contributor
|
There seem to be some HPM changes unrelated to your PR. (Stemming from something merged previously. For the sake of easier reviewable and atomic Commits please split those changes unrelated to you out, if they are missing in master you may start with an "Update HPM Hooks" commit. @MishimaHaruna is the HWSApi that does the HPM Hook updates broken atm? |
guilherme-gm
force-pushed
the
api-autotrade
branch
from
e2a0018 to
9afda07
Compare
Member
Author
|
yup, they are missing in master. updated it |
Member
|
I fixed the failing HWSAPI bot builds, it was due to an expired GPG key. Because of that though, I caused a conflict here, can you please rebase? |
guilherme-gm
force-pushed
the
api-autotrade
branch
from
9afda07 to
6a3f677
Compare
guilherme-gm
commented
Aug 31, 2024
guilherme-gm
commented
Aug 31, 2024
…PI server API server won't have those user accounts and error out, since they won't use the API server anyway, we don't have to send them there
Without this header, HPMHookGen would sometimes generated incomplete/invalid results due to not being able to properly expand macros such as DEFINE_PACKET_ID
guilherme-gm
force-pushed
the
api-autotrade
branch
from
6a3f677 to
3913b51
Compare
MishimaHaruna
approved these changes
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
When map-server starts up and loads autotraders ("standalone" characters), they eventually get sent to char and login server. Once this happen, login-server tries to connect those players in API server, failing, because these players never logged in.
Since those players won't ever be valid, since they are totally system-controlled, this change prevents login-server from sending those accounts to API server, solving the many errors that show up during startup.
I took the chance to convert the packets involved to struct format
Issues addressed: Fixes #3306