Fix AutoSpell not replacing selected skill in some cases#3282
Merged
MishimaHaruna merged 1 commit intoHerculesWS:masterfrom Feb 29, 2024
Merged
Fix AutoSpell not replacing selected skill in some cases#3282MishimaHaruna merged 1 commit intoHerculesWS:masterfrom
MishimaHaruna merged 1 commit intoHerculesWS:masterfrom
Conversation
SC_AUTOSPELL val1 should be the AutoSpell skill level, not the selected skill learned level. This was broken during the refactor and is now fixed. Giving it the selected skill level would prevent restarting the buff mid way if the previous buff had a higher level for the target skill. e.g. a Lv10 Fire Bolt would not be replaced by a Lv5 Earth Spikes
3 tasks
MishimaHaruna
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
SC_AUTOSPELL val1 should be the AutoSpell skill level, not the selected skill learned level. This was broken during the refactor (#3237) and is now fixed.
Thanks to @violent01 for spotting the issue in the rebalance PR ( #3230 (comment) )
Since it was now using the learned level of the selected skill, this lead to cases where switching the selected skill wouldn't work. For example, if you had Fire Bolt Lv10 and Earth Spikes Lv5 (their max), Lv5 would always be less than Lv10, and would be blocked by the default block of every SC (in status.c, which prevents a lower val1 from overriding a higher val1).
Issues addressed:
None