2-2 jobs skill rebalance (Part 1) (2018 patch/Renewal) and small skill fixes#3229
Merged
MishimaHaruna merged 11 commits intoHerculesWS:rebalancefrom May 25, 2024
Merged
Conversation
3 tasks
guilherme-gm
force-pushed
the
old-job-rebalances-3
branch
from
f547eef to
e3e9c88
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-3
branch
from
e3e9c88 to
1c44e4f
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-3
branch
from
1c44e4f to
0f50f51
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-3
branch
from
0f50f51 to
42a1045
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-3
branch
from
42a1045 to
cefbf84
Compare
MishimaHaruna
requested changes
May 24, 2024
- Fixed casting time changed: 1.5s -> 0.5s - Variable casting time changed: 1.5s -> 1s - Global delay changed: 1.5s -> 0.5s - 1s cooldown added - Self damage is removed From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Damage formula changed
- Old: (100 + 30 x SkillLevel)% ATK
Shield weight gives extra flat damage
- Now: (80 x SkillLevel + Shield Weight + Shield Upgrade x 4)% ATK
From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Additionally gives +10% of Equipment ASPD From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Chance of breaking target weapon increased - Old: SkillLevel % - New: (3 x SkillLevel)% - It now uses basic/default meelee damage calculation (instead of special formula) - Damage formula changed: - Old: [100% + (Skill Level x 20)]% (ATK + MATK) - New: [(Skill Level x 60) + (Potion_Research_Lv x 10)]% ATK From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Chance of breaking target armor increased - Old: 3/7/10/12/13% - New: 5/15/25/35/45% - It now uses basic/default ranged physical damage calculation (instead of special formula) - Damage formula changed: - Old: [200% + (Skill Level x 80)]% (ATK + MATK) - New: [(Skill Level x 200) + (Potion_Research_Lv x 100)]% ATK From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
For Renewal Acid Terror damage is applied in a bundle of 5 hits isntead of a single damage
- SP cost reduced: 20 -> 15 - Damage increased - Old: [100 + (Skill Level x 40)]% - New: [50 + (Skill Level x 150)]% - Damage debuff changed - Old: 20% more damage for 5 seconds or 7 hits - New: 30% more damage (15% on boss monsters) for 10 seconds From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
before this commit, only part of the skillratio value was being halved when using bows, because skillratio by default is 100. the correct behavior for bows in backstab is to halve the entire skillratio value (including the initial 100%)
- Skill mechanics changed
- No longer needs to be behind the target to use skill
- No longer ignores accuracy check
- No longer usable from Hiding state
- Now increases skill Hit by 4 per skill level
- Number of hits changed:
- Old: 1 hit
- New: 2 hits with Dagger, 1 hit with other weapons
- SP cost reduced: 16 -> 12
- Cooldown added: 0.5s
- Number of hits changed
From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Also increases Attack Speed by 1% per Skill Level From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
guilherme-gm
force-pushed
the
old-job-rebalances-3
branch
from
cefbf84 to
ac900f2
Compare
MishimaHaruna
approved these changes
May 25, 2024
MishimaHaruna
added a commit
that referenced
this pull request
May 25, 2024
Signed-off-by: Haru <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
This PR depends on #3223 , all commits from #3223 are included in this one. The first commit original to this PR is:
Pull Request Prelude
Draft Reason
This PR by itself is ready and I don't think there will be further changes, unless someone finds an issue or a review asks for some change.
BUT, the rebalance in main official servers came at once, so I believe the right thing to do is to merge this PR together with the rest of the rebalance (that will be in other PRs).
So I will keep this as draft for now, but feel free to give an early review :)
Changes Proposed
The main purpose of this PR is to introduce the rebalance of part of the 2-2 jobs skills. This change affects Renewal-only.
On official servers this came along with rebalances of 1st, 2nd jobs and transclass too. I am working in additional PRs for the remaining 2-2, including bard/dancer, being in separate PRs in order to keep those PRs in a reasonable size.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the rebalance changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Affected jobs/skills
References:
Additionally, there were 3 changes not related to the rebalance patch that is being applied in this PR (since it just appeared exactly where I was touching 😅 )
Huge thanks to Asheraf and skyleo for helping me with some tests/validations of how it should work.
Issues addressed:
Part of #2727