Draft
Conversation
From this patch: https://www.divine-pride.net/forum/index.php?/topic/3453-kro-mass-skills-balance-1st-2nd-and-transcendent-classes-skills/ All skills that were reworked were tested and seem to be working correctly. If I miss anything let me know NOT IMPLEMENTED: -Basilica (completely new skill) -AMP (completely new skill) -Harmonic Lick (completely new skill) -Classical Pluck (todo: add CONFUSION to the aoe effect) Also, Bowling Bash should only have 4 hits on 4 or more targets with 2h sword. Atm I only implemented 4 hits with 2h sword at all instances (which I think it's fair). Additional content: Some skill were later (2022) adjusted again in kro, I might have already updated them (like songs lasting 180sec).
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
ghost
reviewed
Apr 22, 2023
Author
|
Thanks Mishima, I've been terribly busy with work (and sick with covid also), also I'm not particularly good at github, so for now that's all I can contribute. |
3 tasks
3 tasks
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the skill changes from this patch: https://www.divine-pride.net/forum/index.php?/topic/3453-kro-mass-skills-balance-1st-2nd-and-transcendent-classes-skills/
All skills that were reworked were tested and seem to be working correctly. If I miss anything let me know
NOT IMPLEMENTED:
-Basilica (completely new skill);
-AMP (completely new skill);
-Harmonic Lick (completely new skill);
-Classical Pluck (todo: add CONFUSION to the aoe effect);
-New Falcon Assault formula (IRO formula seems weird/wrong and I couldnt find another source).
Also, Bowling Bash should only have 4 hits on 4 or more targets with 2h sword. Atm I only implemented 4 hits with 2h sword at all instances (which I think it's fair).
Additional content: Some skill were later (2022) adjusted again in kro, I might have already updated them (like songs lasting 180sec).
PS: btw, Hindsight skill from Professor seems very convoluted on skill.c, large portions of code doesnt seem to do anything, I recommend someone clean it up.