Fixed Rogue's plagiarize losing skills when copying skills from its own skill tree#14
Merged
csnv merged 1 commit intoHeraclesHub:masterfrom Apr 14, 2024
Merged
Conversation
csnv
force-pushed
the
fix/rogue-plagiarize
branch
3 times, most recently
from
0f12b51 to
e6668b1
Compare
csnv
force-pushed
the
fix/rogue-plagiarize
branch
from
e6668b1 to
c84f47d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
By submitting this Pull Request I confirm I have followed proper Hercules code styling and that I have read and understood the contribution guidelines.
Changes Proposed
Fixed Rogue's plagiarize losing skills when copying skills from its own skill tree.
In addition, this fixes other instances in recent clients where equipment or altered status grant skills that already were in the character skilltree and weren't removed from the client side skill tree once the equipment was unequipped or the status finished.
Issues addressed:
Hercules issue HerculesWS/Hercules#3289