Skip to content

Describe tool access for members without a role correctly in the roles API - #1669

Merged
helpcodeai merged 2 commits into
mainfrom
fix/roles-tool-access-description
Nov 13, 2026
Merged

helpcodeai merged 2 commits into
mainfrom
fix/roles-tool-access-description

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

The OpenAPI description of PUT /api/roles/{id}/tools said that members without an MCP role "keep unrestricted access", and a code comment in McpServerService said the same. That is only true while no role of the workspace has a tool list; once one does, a member without a role gets no tools (RolesService.getAllowedToolIds). Same correction as #1662 made in the UI.

Text only, no behaviour change. Same in Cloud and self-hosted.

Changes

  • roles.controller.ts: the toolIds description states both cases.
  • mcp-server.service.ts: comment on registerMcpTool.

Type

  • Bug fix
  • New feature
  • Documentation
  • Refactoring
  • Performance improvement
  • Other (describe below)

Testing

  • Added/updated unit tests
  • Tested manually (describe steps below)
  • No tests needed (explain why)

A description string and a comment. node scripts/generate-cli-operations.mjs --check (root): up to date (the generated file carries no descriptions).

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • I have updated documentation (if applicable)
  • All existing tests pass (npm test) (CI)
  • This PR has a descriptive title

Related Issues

Follow-up to #1662.

@helpcodeai
helpcodeai merged commit 264be1f into main Nov 13, 2026
15 of 16 checks passed
@helpcodeai
helpcodeai deleted the fix/roles-tool-access-description branch November 13, 2026 18:26
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant