Repository navigation
Describe tool access for members without a role correctly in the roles API - #1669
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OpenAPI description of
PUT /api/roles/{id}/toolssaid that members without an MCP role "keep unrestricted access", and a code comment inMcpServerServicesaid the same. That is only true while no role of the workspace has a tool list; once one does, a member without a role gets no tools (RolesService.getAllowedToolIds). Same correction as #1662 made in the UI.Text only, no behaviour change. Same in Cloud and self-hosted.
Changes
roles.controller.ts: thetoolIdsdescription states both cases.mcp-server.service.ts: comment onregisterMcpTool.Type
Testing
A description string and a comment.
node scripts/generate-cli-operations.mjs --check(root): up to date (the generated file carries no descriptions).Checklist
npm test) (CI)Related Issues
Follow-up to #1662.