Repository navigation
Update soupsieve to 4.0.1 in the file extractor - #1661
Merged
Merged
Conversation
Contributor
Author
|
Added: the image tag in both compose files goes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot alerts #134 and #135 (high):
soupsieve< 4.0.0 has a polynomial-time selector match. The file extractor gets it throughextract-msg→beautifulsoup4; both lock files pinned 3.0.3. This PR pins 4.0.1.The lock files only take versions published before a cutoff (supply-chain cool-down). 4.0.0 came out on 3 Nov, so the cutoff moves from 17 Oct to 4 Nov, and
requirements.ingets a floorsoupsieve>=4.0.0so a later compile cannot go back. No other package version changes: the compile keeps the existing pins.This touches
deploy/ee/(commercial licence); the maintainer approved the change. Cloud and self-hosted Enterprise get it when the extractor image is rebuilt.Changes
deploy/ee/file-extractor/requirements.in:soupsieve>=4.0.0with the reason.compile-requirements.sh: defaultCUTOFF2026-11-04.requirements.txt,requirements-ocr.txt:soupsieve3.0.3 → 4.0.1 (hashes), header cutoff.requirements-dev.txt: header cutoff only.Type
Testing
deploy/ee/file-extractor:sh compile-requirements.sh: the diff of the two runtime lock files issoupsieveonly.sh test.sh: pytest on the host 227 passed, 7 skipped; inside the image 229 passed, 5 skipped; HTTP checks on the hardened container OK (xlsx, pdf page numbers, pdf page as jpeg, 401 on a wrong token, health); no outbound network OK; "all file-extractor tests passed".Checklist
npm test) (extractor suite locally, the rest in CI)Related Issues
Fixes Dependabot alerts #134 and #135.