Skip to content

Describe the single 429 retry correctly in two adapters - #1651

Merged
helpcodeai merged 1 commit into
mainfrom
fix/adapter-429-retry-wording
Nov 12, 2026
Merged

helpcodeai merged 1 commit into
mainfrom
fix/adapter-429-retry-wording

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1648. Two adapters told the model that the connector retries a 429 automatically with (exponential) backoff. The REST engine retries a 429 exactly once (retryDelayMs in rest.engine.ts: after Retry-After when it is at most 3 s, after about a second when there is none, not at all when it is longer), so the model may wrongly assume a throttled call was retried several times.

Changes

  • intl/amazon-seller.json: the rate-limit sentence now describes the single retry and asks to wait before calling again.
  • intl/google-analytics-4.json: same for the 429 line under quotas.
  • Other adapters that say "429 → exponential backoff" (Nimble, OpenWeather, Zoho CRM) only advise the model what to do and are left as they are.

Type

  • Bug fix

Testing

  • No tests needed (instruction text only)
  • From the repo root: node scripts/regenerate-catalog.mjs → no diff (catalog.ts carries no instruction text); node scripts/validate-adapters.mjs --warn → exit 0, output identical to the same run without the change (no new warnings).

Checklist

  • My code follows the existing code style
  • This PR has a descriptive title

Related Issues

Follow-up to #1648.

@helpcodeai
helpcodeai requested a review from D3nisty as a code owner November 12, 2026 17:28
@helpcodeai
helpcodeai enabled auto-merge (squash) November 12, 2026 17:29
@helpcodeai
helpcodeai merged commit 93f913c into main Nov 12, 2026
17 checks passed
@helpcodeai
helpcodeai deleted the fix/adapter-429-retry-wording branch November 12, 2026 17:48
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant