Repository navigation
Describe the single 429 retry correctly in two adapters - #1651
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1648. Two adapters told the model that the connector retries a 429 automatically with (exponential) backoff. The REST engine retries a 429 exactly once (
retryDelayMsinrest.engine.ts: afterRetry-Afterwhen it is at most 3 s, after about a second when there is none, not at all when it is longer), so the model may wrongly assume a throttled call was retried several times.Changes
intl/amazon-seller.json: the rate-limit sentence now describes the single retry and asks to wait before calling again.intl/google-analytics-4.json: same for the 429 line under quotas.Type
Testing
node scripts/regenerate-catalog.mjs→ no diff (catalog.ts carries no instruction text);node scripts/validate-adapters.mjs --warn→ exit 0, output identical to the same run without the change (no new warnings).Checklist
Related Issues
Follow-up to #1648.