Repository navigation
List valid SAP B1 OriginalJournal names and item fields - #1646
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1476. Production use of the SAP Business One adapter (B1 10.0 FP2511, Service Layer v2) still shows two kinds of
400errors from guessed names:JournalEntriesfilters onOriginalJournalwith names that do not exist inTransTypesEnum, e.g.ttDeliveryNote(real namettDelivery) andttAPCreditMemo(real namettAPCreditNote). SAP answers with error-1013. The A/R credit memo is spelledttARCredItnotein SAP, which the model cannot guess. The instructions and the journal entryfilterdescription now list the valid names.Items:LastPurchasePriceandProductTreeTypedo not exist ("Property 'X' of 'Item' is invalid"). The instructions and the itemsselectdescription now point toItemPrices.Changes are text only (instructions and parameter descriptions). No tool names, paths or parameters change. Behaviour is the same in Cloud and self-hosted.
Test plan
OriginalJournal eq 'ttARCredItnote','ttAPCreditNote','ttDelivery','ttDeposit'and$select=ItemCode,ItemPricesall return rows.node scripts/validate-adapters.mjs --warn(root): 0 failed;de/sap-business-one.jsononly has the existingtool-prefixwarnings.node scripts/regenerate-catalog.mjs(root): no diff incatalog.ts.npx jest src/adapters/de/sap-business-one.live.spec.ts --maxWorkers=2(packages/backend): 6 passed, 1 skipped (live calls gated).