Repository navigation
Give catalog resync transactions 30 s so large connectors sync at boot - #1643
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The catalog resync updates every tool row of a connector in one interactive Prisma transaction with the default 5 s timeout. On 11-11, two boot auto-syncs of WooCommerce connectors were skipped with "expired transaction" (11:00 and 12:31 UTC); they only retry at the next boot. The transaction now gets
maxWait10 s andtimeout30 s.Changes
catalog-resync.service.ts:RESYNC_TRANSACTIONpassed to the resync$transaction.Type
Testing
npx jest src/connectors/catalog-resyncinpackages/backend: 42/42.npx eslinton both files clean. Full checks in CI.Same in Cloud and self-hosted. No schema change, nothing in
ee/.Checklist
npm test) (CI)