Repository navigation
fix(adapters): filemaker recordId naming and database names with spaces - #1640
Merged
Merged
Conversation
…tabase names with spaces
Contributor
|
Merged, thank you! Thanks also for testing a database name with spaces on a real FileMaker Server. The change ships with our next Cloud deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1624 with the two non-blocking points from the review.
Changes
filemaker_get_recordnow names its parameterrecordId(wasrecord_id), the same asfilemaker_get_layout_metadata. Path:/layouts/{layout}/records/{recordId}. The spec is updated.My Contacts. The engine URL-encodes it (.../databases/My%20Contacts/sessions), so no engine change was needed. Setup step 2 in the instructions now says to type the name as shown, spaces included.Checks
FILEMAKER_DATABASE="My Contacts": 21/21 passed (login, list layouts, metadata, find, get record, empty find, 401 re-login).validate-adapters --warn: no FileMaker warnings.adapter-count --check: OK. Regenerating the catalog and llms files gives no diff.Note: the renamed parameter is a small breaking change for anyone who already calls
filemaker_get_recordwithrecord_id. The adapter only shipped yesterday, so the impact should be minimal.