Repository navigation
Fix Falabella order filters, Substack cursor paging and empty Gemini answers - #1628
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three adapter bugs seen in Cloud tool errors on 11-10, all in the adapter JSON we ship.
get_orders: thesort_byenum offeredcreatedat/updatedatand thestatusenumreadytoship. Falabella refuses them (E075: Invalid sort filteron 6 of 6 calls,E036: Invalid status filteron 3 of 3). The GetOrders reference documentscreated_at/updated_atandpending, canceled, ready_to_ship, delivered, returned, shipped, failed.{ posts, nextCursor }instead of an array, refuses anyoffset(even 0) and refuseslimitabove 25. Our excludes ([*].body_html…) no longer matched, so full post bodies went back to the model, and every second-page call failed. Checked live on three publications today.generate_text/generate_content/analyze_file_url: a candidate withoutcontent.parts(safety stop, empty answer) madejoin()fail on null, and the raw response went back unshaped (about once a day).Changes
falabella-seller-center.json: correctsort_byandstatusenums (addsfailed).substack.json:limitmaximum 25,offsetreplaced bycursor(the previousnextCursor), excludes now underposts[*], descriptions and instructions explain the new paging.gemini.json:join('', … .text || \[]`)` in the three mappings.Description and instruction changes sync on their own. The parameter changes (Substack
cursor, the enums) are structural, so installed connectors get them after "Apply update"; new installs get them at once.Type
Testing
In
packages/backend(Prisma client generated in the worktree):npx jest src/adapters/intl/substack src/adapters/intl/gemini src/adapters/intl/falabella-seller-center: 4 suites, 71 passed (8 live tests skipped).RUN_SUBSTACK_LIVE=1 npx jest src/adapters/intl/substack: 25 passed against lennysnewsletter.com.npx eslinton the three specs: clean.From the root:
node scripts/validate-adapters.mjs --warn(no warning for these adapters),node scripts/regenerate-catalog.mjs(no diff),node scripts/adapter-count.mjs --checkOK.Checklist
npm test) (adapter suites locally, full suite in CI)Same behaviour in Cloud and self-hosted.
Related Issues
None (found in the 11-11 daily check).