Skip to content

Check the Odoo address before a chat install and report ready connectors that fail - #1610

Merged
helpcodeai merged 2 commits into
mainfrom
feat/chat-setup-odoo-checks
Nov 9, 2026
Merged

helpcodeai merged 2 commits into
mainfrom
feat/chat-setup-odoo-checks

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

Installs started from a chat (setup_install_connector, also used by the post-approve app picker) did not benefit from what the setup check learned about Odoo. In 14 days, 315 Odoo connectors were installed this way, 139 of them with a database name the assistant passed (often the subdomain, which on Odoo Online and Odoo.sh is not the database), and the JSON-2 connector was installed on Odoos below 19, found out only on the setup page. Separately, setup_get_status said "ready" as soon as every value was filled in, also for a connector saved with wrong values via "Save anyway".

Changes

  • inspectOdooAddress (odoo-database-hint.ts): asks the address, without a key and in parallel, for common.version and /web/database/list.
  • setup_install_connector, Odoo only, when an address is passed:
    • no database at the address (Odoo Online's typo page): refused before anything is installed, with what to ask the user;
    • JSON-2 connector on an Odoo below 19: the Odoo 14-18 (JSON-RPC) connector is installed instead;
    • one database served: its name is used, whatever the assistant passed;
    • several, and the one passed is not among them: not passed, and the answer names them;
    • the answer says what was changed (checkedTheAddress). When the address says nothing, the install is unchanged.
  • setup_get_status: each ready connector carries its last call (worked, or the error), and up to three catalog connectors finished in the last 24 h and never used get the setup check on their stored values, with a fixUrl when it fails. The tool description mentions it (no new tool).

Cloud and self-hosted behave the same. The Odoo requests go only to the address the user gave, through the SSRF-guarded client.

Type

  • New feature

Testing

  • Added/updated unit tests
cd packages/backend
npx tsc --noEmit -p tsconfig.json                                    # clean
npx jest --maxWorkers=4 src/adapters src/mcp-server src/connectors   # 871 suites passed, 5 skipped; 28390 tests passed
npm run lint                                                         # clean

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • All existing tests pass
  • This PR has a descriptive title

@helpcodeai
helpcodeai requested a review from D3nisty as a code owner November 9, 2026 15:17
@helpcodeai
helpcodeai enabled auto-merge (squash) November 9, 2026 15:17
@helpcodeai
helpcodeai merged commit bcaa07f into main Nov 9, 2026
16 checks passed
@helpcodeai
helpcodeai deleted the feat/chat-setup-odoo-checks branch November 9, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant