Repository navigation
Check the Odoo address before a chat install and report ready connectors that fail - #1610
Merged
Merged
Conversation
helpcodeai
enabled auto-merge (squash)
November 9, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Installs started from a chat (
setup_install_connector, also used by the post-approve app picker) did not benefit from what the setup check learned about Odoo. In 14 days, 315 Odoo connectors were installed this way, 139 of them with a database name the assistant passed (often the subdomain, which on Odoo Online and Odoo.sh is not the database), and the JSON-2 connector was installed on Odoos below 19, found out only on the setup page. Separately,setup_get_statussaid "ready" as soon as every value was filled in, also for a connector saved with wrong values via "Save anyway".Changes
inspectOdooAddress(odoo-database-hint.ts): asks the address, without a key and in parallel, forcommon.versionand/web/database/list.setup_install_connector, Odoo only, when an address is passed:checkedTheAddress). When the address says nothing, the install is unchanged.setup_get_status: each ready connector carries its last call (worked, or the error), and up to three catalog connectors finished in the last 24 h and never used get the setup check on their stored values, with afixUrlwhen it fails. The tool description mentions it (no new tool).Cloud and self-hosted behave the same. The Odoo requests go only to the address the user gave, through the SSRF-guarded client.
Type
Testing
Checklist