Repository navigation
Correct weclapp invoice and Business Central filter hints - #1549
Merged
Merged
Conversation
helpcodeai
enabled auto-merge (squash)
November 6, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two catalog adapters told the model to send filters the vendor refuses. Found in the 11-06 daily check (Cloud tool errors, last 30 days).
weclapp
weclapp_list_invoices. The field list namedsalesOrderIdas an invoice field and mappedsalesOrderNumberto it. weclapp has no such filter on invoices:salesOrderId-eq=…failed 16 of 16 times ("unexpected filter property") in 7 workspaces.salesOrders.id-eq=…worked 13 of 13 times. The description now gives that filter, andsalesOrderIdleaves the list of valid invoice fields.Business Central.
oracross different fields answers 501BadRequest_MethodNotImplemented(13 errors in 3 workspaces over 14 days);oron the same field works (hundreds of successful calls).taxRegistrationNumbercannot be filtered (4 errors). One line in the connector instructions says both.Changes
packages/backend/src/adapters/de/weclapp.json:weclapp_list_invoicesdescription andpropertiestext.packages/backend/src/adapters/intl/dynamics365-business-central.json: one line in the Filtering section of the instructions.Text only. These are the safe class: catalog auto-sync applies them at boot, on Cloud and self-hosted, except to connectors whose instructions the user edited.
Type
Testing
From the repository root:
node scripts/validate-adapters.mjs --warn: exit 0, no new warnings (thebc_tool-prefix warnings are old).node scripts/regenerate-catalog.mjs: no diff.node scripts/adapter-count.mjs --check: OK, 713 adapters.In
packages/backend:npx jest src/adapters/de/weclapp.spec.ts: 7 passed. The full suite runs in CI.Checklist
npm test): CI runs the full suiteRelated Issues
Daily check 2026-11-06.