Skip to content

Correct weclapp invoice and Business Central filter hints - #1549

Merged
helpcodeai merged 2 commits into
mainfrom
fix/weclapp-bc-filter-hints
Nov 6, 2026
Merged

helpcodeai merged 2 commits into
mainfrom
fix/weclapp-bc-filter-hints

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

Two catalog adapters told the model to send filters the vendor refuses. Found in the 11-06 daily check (Cloud tool errors, last 30 days).

weclapp weclapp_list_invoices. The field list named salesOrderId as an invoice field and mapped salesOrderNumber to it. weclapp has no such filter on invoices: salesOrderId-eq=… failed 16 of 16 times ("unexpected filter property") in 7 workspaces. salesOrders.id-eq=… worked 13 of 13 times. The description now gives that filter, and salesOrderId leaves the list of valid invoice fields.

Business Central. or across different fields answers 501 BadRequest_MethodNotImplemented (13 errors in 3 workspaces over 14 days); or on the same field works (hundreds of successful calls). taxRegistrationNumber cannot be filtered (4 errors). One line in the connector instructions says both.

Changes

  • packages/backend/src/adapters/de/weclapp.json: weclapp_list_invoices description and properties text.
  • packages/backend/src/adapters/intl/dynamics365-business-central.json: one line in the Filtering section of the instructions.

Text only. These are the safe class: catalog auto-sync applies them at boot, on Cloud and self-hosted, except to connectors whose instructions the user edited.

Type

  • Bug fix

Testing

  • Added/updated unit tests
  • Tested manually (describe steps below)
  • No tests needed (explain why): description text only. Checks run:

From the repository root:

  • node scripts/validate-adapters.mjs --warn: exit 0, no new warnings (the bc_ tool-prefix warnings are old).
  • node scripts/regenerate-catalog.mjs: no diff.
  • node scripts/adapter-count.mjs --check: OK, 713 adapters.

In packages/backend: npx jest src/adapters/de/weclapp.spec.ts: 7 passed. The full suite runs in CI.

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • I have updated documentation (if applicable)
  • All existing tests pass (npm test): CI runs the full suite
  • This PR has a descriptive title

Related Issues

Daily check 2026-11-06.

@helpcodeai
helpcodeai requested a review from D3nisty as a code owner November 6, 2026 08:21
@helpcodeai
helpcodeai enabled auto-merge (squash) November 6, 2026 08:21
@helpcodeai
helpcodeai merged commit 3ac1d4e into main Nov 6, 2026
16 checks passed
@helpcodeai
helpcodeai deleted the fix/weclapp-bc-filter-hints branch November 6, 2026 08:48
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant