Repository navigation
Show the HTTP status in the REST engine's gave-up warning - #1505
Merged
Merged
Conversation
helpcodeai
enabled auto-merge (squash)
November 4, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The REST engine's warning "Gave up after N attempts on a transient upstream failure: " printed
error.codefirst. axios also sets a code on HTTP errors (ERR_BAD_REQUESTfor every 4xx), so a rate limit was logged asERR_BAD_REQUESTinstead of429. Cloud logged 85 such lines on 3-4 Nov (DHL 55), which made rate limits look like bad requests in the log review.Changes
ERR_BAD_REQUESTlike a real axios error. The existing assertions on "… failure: 429 …" fail without the fix.Log text only: nothing changes in what the tool returns. Cloud and self-hosted behave the same.
Type
Testing
In
packages/backend:npx jest src/connectors/engines/rest.engine --maxWorkers=4→ 202 passed (log-redaction: 2 of 5 fail without the fix)npx eslinton the changed files → exit 0Checklist
npm test)Related Issues
Found in the 2026-11-04 Cloud log review.