Repository navigation
Probe eBay Sell with seller privileges instead of policies - #1504
Merged
Merged
Conversation
The setup check listed fulfilment policies, which eBay refuses with error 20403 for sellers who do not use Business Policies. Those connectors work, but the setup page reported them as broken. Probe the privilege endpoint, which every seller account can read, and document the 20403 answer of the two policy tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The eBay Sell setup check called
ebay_sell_list_fulfillment_policies. eBay answers that endpoint with error 20403 "User is not eligible for Business Policy" for every seller who does not use Business Policies. For those sellers the connection works (orders, privileges and inventory read fine), but the setup page reported a failed check. A seller in support created a second connector because of it.Changes
probeandhealthcheckPathnow useebay_sell_get_privileges/GET /sell/account/v1/privilege, which every seller account can read with thesell.accountscope the connector already requests.Cloud and self-hosted behave the same: the adapter JSON is shared. On Cloud, the boot catalog sync applies the new instructions to installed connectors whose instructions were not edited.
Type
Testing
Commands run in a worktree of this branch:
node scripts/validate-adapters.mjs --warn(repo root): 709 passed, 0 failed; no warning forebay-sell.node scripts/regenerate-catalog.mjs(repo root): no diff incatalog.ts.npx prisma generateand thennpx jest --maxWorkers=4 src/adapters/intl/ebay-sell src/connectors/connector-authorization.spec.ts src/adapters/catalog(packages/backend): 5 suites passed, 14859 tests passed, 1 skipped (the live spec).catalog-summary.spec.tsdid not compile locally:@types/picomatchis missing in the sharednode_modules. That is a baseline environment issue left to CI, not a regression.Checklist