Repository navigation
Keep File Search from crowding out the app a search names (#1457) - #1458
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The File Search suggestions added in #1433 work for storage queries ("nas", "synology"), but today's Cloud search logs show File Search entries pushing aside the app people actually searched for: "lexware dokumente" opened with SFTP and WebDAV, "amazon" listed S3 among the Amazon connectors, "excel" filled the chat's five results with File Search entries. This keeps the suggestions where they help and out of the way elsewhere. Same behaviour on Cloud and self-hosted (the search is shared by the store, /welcome and the chat).
Changes
Type
Testing
Commands (all in
packages/backendunless noted):npx jest src/adapters/catalog-search.spec.ts --maxWorkers=4→ 80 passednpx jest src/adapters/connector-setup.service.spec.ts src/adapters/intl/onec-enterprise.live.spec.ts src/adapters/intl/shopee.live.spec.ts src/adapters/intl/xero.live.spec.ts src/mcp-server/shared-toolset.discoverability.spec.ts src/adapters/mcp-adapter.spec.ts --maxWorkers=4→ 176 passed, 2 skipped (live)npx tsc --noEmit -p tsconfig.json→ cleannpx eslinton the changed files (backend and frontend) → cleanpackages/frontend:npx tsc --noEmit -p tsconfig.json→ cleanChecklist
Related Issues
Fixes #1457. Follows #1433.