Skip to content

Keep File Search from crowding out the app a search names (#1457) - #1458

Merged
helpcodeai merged 1 commit into
mainfrom
fix/catalog-search-file-search-noise
Nov 2, 2026
Merged

helpcodeai merged 1 commit into
mainfrom
fix/catalog-search-file-search-noise

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

The File Search suggestions added in #1433 work for storage queries ("nas", "synology"), but today's Cloud search logs show File Search entries pushing aside the app people actually searched for: "lexware dokumente" opened with SFTP and WebDAV, "amazon" listed S3 among the Amazon connectors, "excel" filled the chat's five results with File Search entries. This keeps the suggestions where they help and out of the way elsewhere. Same behaviour on Cloud and self-hosted (the search is shared by the store, /welcome and the chat).

Changes

  • A word about documents in general ("pdf", "Dokumente", "files") suggests nothing when another word names an app (name or alias match on a non-File-Search adapter). With one such app word ("excel files", "lexware dokumente") the document word is dropped, so the app is found directly.
  • For a query with no File Search intent, a File Search entry met only through an alias ("Amazon S3", "QuTS hero") ranks after the other direct results and after fuzzy ones; one met only in its description ("PDF, Excel, Word and Outlook files") is left out.
  • Storage-system queries are unchanged: "synology", "nextcloud", "nas", "minio", "amazon s3" still put File Search at the top.
  • Frontend copy of catalog-search.ts updated byte for byte.
Query Before After
lexware dokumente sftp, webdav, lexware-office lexware-office
excel files sftp, webdav, … microsoft-excel
telegram send document telegram-bot + File Search hint telegram-bot, no hint
amazon amazon-ads, amazon-seller, s3-file-search, helium10 amazon-ads, amazon-seller, helium10, scrapingbee, s3-file-search
hero qnap-file-search, here-geocoding here-geocoding, qnap-file-search
excel / word / outlook app + 7–8 File Search entries app only
aws s3-file-search s3-file-search

Type

  • Bug fix

Testing

  • Added/updated unit tests: 14 new cases in catalog-search.spec.ts (one per query above, plus "aws" still finds S3 and "gmail attachments pdf" keeps "pdf").

Commands (all in packages/backend unless noted):

  • npx jest src/adapters/catalog-search.spec.ts --maxWorkers=4 → 80 passed
  • npx jest src/adapters/connector-setup.service.spec.ts src/adapters/intl/onec-enterprise.live.spec.ts src/adapters/intl/shopee.live.spec.ts src/adapters/intl/xero.live.spec.ts src/mcp-server/shared-toolset.discoverability.spec.ts src/adapters/mcp-adapter.spec.ts --maxWorkers=4 → 176 passed, 2 skipped (live)
  • npx tsc --noEmit -p tsconfig.json → clean
  • npx eslint on the changed files (backend and frontend) → clean
  • packages/frontend: npx tsc --noEmit -p tsconfig.json → clean

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • I have updated documentation (the file header documents the new rules)
  • All existing tests pass (targeted suites above)
  • This PR has a descriptive title

Related Issues

Fixes #1457. Follows #1433.

@helpcodeai
helpcodeai enabled auto-merge (squash) November 2, 2026 19:05
@helpcodeai
helpcodeai merged commit 638a63c into main Nov 2, 2026
15 checks passed
@helpcodeai
helpcodeai deleted the fix/catalog-search-file-search-noise branch November 2, 2026 19:19
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connector search: File Search entries crowd out the app the query names

1 participant