Skip to content

Install catalog tools that declare no parameters - #1435

Merged
helpcodeai merged 2 commits into
mainfrom
fix/catalog-tools-without-parameters
Nov 2, 2026
Merged

helpcodeai merged 2 commits into
mainfrom
fix/catalog-tools-without-parameters

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

A catalog tool that takes no arguments may leave parameters out of its JSON, but mcp_tools.parameters is a required column. The install's batch insert then failed and the one-by-one fallback skipped those tools ("Argument parameters is missing"): an OpenRouter install on Cloud on 2 Nov lost openrouter_list_providers and openrouter_get_current_key. On main, 14 adapters have 37 such tools (mailtrap, power-bi, clay, cohere, mem0, groq, freshsales, langfuse, smartlead and others). A "full" catalog update (catalog-resync.service.ts) creates tools the same way.

The catalog now defaults a missing parameters to {} when it loads, so the install and the update both get a value. {} is what toolFingerprint already uses for a missing value, so no adapter version changes and no connector sees a spurious "Catalog update available".

Same in Cloud and self-hosted (shared catalog).

Changes

  • packages/backend/src/adapters/catalog.ts: withDefaultParameters runs first on the raw adapters (hand-written code, outside the AUTOGEN markers).
  • packages/backend/src/adapters/catalog.spec.ts: every catalog tool has a parameters object; openrouter_list_providers gets {}.

Type

  • Bug fix

Testing

  • Added/updated unit tests
  • Backend tests run in CI. Locally the worktree had no dependencies of its own, so the jest run is left to CI.

Notes

Connectors installed before this fix keep missing those tools; a new install or an adapter update brings them.

@helpcodeai
helpcodeai requested a review from D3nisty as a code owner November 2, 2026 08:14
@helpcodeai
helpcodeai enabled auto-merge (squash) November 2, 2026 08:30
@helpcodeai
helpcodeai merged commit 04995cb into main Nov 2, 2026
14 checks passed
@helpcodeai
helpcodeai deleted the fix/catalog-tools-without-parameters branch November 2, 2026 08:54
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant