Repository navigation
Install catalog tools that declare no parameters - #1435
Merged
Merged
Conversation
helpcodeai
enabled auto-merge (squash)
November 2, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A catalog tool that takes no arguments may leave
parametersout of its JSON, butmcp_tools.parametersis a required column. The install's batch insert then failed and the one-by-one fallback skipped those tools ("Argumentparametersis missing"): an OpenRouter install on Cloud on 2 Nov lostopenrouter_list_providersandopenrouter_get_current_key. Onmain, 14 adapters have 37 such tools (mailtrap, power-bi, clay, cohere, mem0, groq, freshsales, langfuse, smartlead and others). A "full" catalog update (catalog-resync.service.ts) creates tools the same way.The catalog now defaults a missing
parametersto{}when it loads, so the install and the update both get a value.{}is whattoolFingerprintalready uses for a missing value, so no adapter version changes and no connector sees a spurious "Catalog update available".Same in Cloud and self-hosted (shared catalog).
Changes
packages/backend/src/adapters/catalog.ts:withDefaultParametersruns first on the raw adapters (hand-written code, outside the AUTOGEN markers).packages/backend/src/adapters/catalog.spec.ts: every catalog tool has aparametersobject;openrouter_list_providersgets{}.Type
Testing
Notes
Connectors installed before this fix keep missing those tools; a new install or an adapter update brings them.