Repository navigation
Treat Chrome's "network error" as a lost connection - #1434
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome raises
TypeError: network errorwhen the connection drops while a response body is being read.isNetworkErrordid not know this wording, so a user on Cloud got the generic "Something went wrong" screen instead of the "Connection lost" page that reloads by itself once the network is back (Sentry ANYTHINGMCP-CLOUD-FRONTEND-G).Cloud and self-hosted behave the same: this is the shared frontend error boundary.
Changes
packages/frontend/src/lib/network-error.ts: add/^network error$/ito the recognised messages (exact match, so longer messages that merely contain the words are not caught).packages/frontend/tests/e2e/network-drop.spec.ts: one more assertion in theisNetworkErrortest.Type
Testing
network errorandNetwork Error, notnetwork error x.playwright.yml).Checklist
Related Issues
Sentry ANYTHINGMCP-CLOUD-FRONTEND-G