Skip to content

Give the File Search file as a link that every AI client can open (#1384) - #1399

Merged
helpcodeai merged 1 commit into
mainfrom
fix/file-search-get-file-link
Nov 1, 2026
Merged

Give the File Search file as a link that every AI client can open (#1384)#1399
helpcodeai merged 1 commit into
mainfrom
fix/file-search-get-file-link

Conversation

@helpcodeai

@helpcodeai helpcodeai commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Found in the production test from Claude.ai in the browser: _get_file returned a 980 KB PDF as an embedded resource (application/pdf). Claude.ai does not display embedded PDFs, so the user received nothing; Claude itself reported it.

Changes

  • With File Share on the plan, _get_file always returns a temporary internal link (24 hours). It opens for signed-in members of the workspace, in every client. Images up to 4 MB are attached as well.
  • Without File Share (Cloud trial), files up to 4 MB are attached as before, and the result now includes the path, so the model can name it if the client cannot show the attachment.
  • BinaryBody gets optional extra fields, rendered next to the attachment in the text part (used for the link).
  • The tool description, the guide tool and the docs say the same.

Cloud and self-hosted behave the same; the link needs a plan with File Share.

Type

  • Bug fix

Testing

  • Added/updated unit tests
Directory Command Result
packages/backend npx tsc --noEmit -p tsconfig.json clean
packages/backend npm run lint 0 errors, 11 warnings (existing)
packages/backend npx jest src/file-search src/connectors/binary src/connectors/engines --maxWorkers=4 50 suites, 847 passed
packages/backend npx jest src/connectors/binary-response.util.spec.ts 16 passed (new: extra fields)
root node scripts/generate-llms-txt.mjs --check fresh

Related Issues

Relates to #1384, #1379.

@helpcodeai
Give the File Search file as a link that every AI client can open (#1384
5033305 
)

Claude.ai does not show a PDF attached as an embedded resource, so
_get_file gave the user nothing. With File Share on the plan it now
returns a temporary internal link (images are attached as well); without
it, small files are attached and the model names the path.
@helpcodeai
helpcodeai enabled auto-merge (squash) November 1, 2026 16:03
@helpcodeai
helpcodeai merged commit dfdd785 into main Nov 1, 2026
15 checks passed
@helpcodeai
helpcodeai deleted the fix/file-search-get-file-link branch November 1, 2026 16:14
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@helpcodeai