Skip to content

Mask the remaining e-mail addresses in backend logs - #1375

Merged
helpcodeai merged 2 commits into
mainfrom
fix/mask-remaining-emails
Nov 1, 2026
Merged

helpcodeai merged 2 commits into
mainfrom
fix/mask-remaining-emails

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

#1359 masked the trial and lifecycle mails, but the Cloud backend log still had about 1,430 lines with a full e-mail address in the last 23 hours: onboarding reminders (866), social sign-in on the authorize page (~360), dashboard approvals (~170), login warnings and trial licence retries. Addresses are personal data and do not belong in the log.

Changes

  • Every remaining logger line outside ee/ that printed an address now prints maskEmail(...) (ad***@example.com), the helper Mask recipient addresses in the e-mail service logs #1359 already uses: 12 lines in settings/email.service.ts, 7 in auth/login.controller.ts, 3 in auth/auth.controller.ts, 4 in license/license.service.ts. Log text only, no behaviour change.
  • Specs: the onboarding reminder joins the existing masking test in email.service.spec.ts; a new test in login.controller.spec.ts checks the unknown-user, wrong-password and successful-login lines.

Type

  • Bug fix

Testing

  • Added/updated unit tests

In packages/backend: npx jest src/settings/email.service.spec.ts src/auth/login.controller.spec.ts src/auth/login.controller.social.spec.ts src/license src/auth/auth.controller (12 suites, 295 passed), npx eslint on the six files, npx tsc --noEmit -p tsconfig.json. Same behaviour in Cloud and self-hosted.

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • All existing tests pass
  • This PR has a descriptive title

Related Issues

Follow-up to #1359. Daily check 2026-11-01, cloud.md candidate 1.

@helpcodeai
helpcodeai enabled auto-merge (squash) November 1, 2026 09:27
@helpcodeai
helpcodeai merged commit dcd48af into main Nov 1, 2026
14 checks passed
@helpcodeai
helpcodeai deleted the fix/mask-remaining-emails branch November 1, 2026 09:38
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant