Repository navigation
Mask the remaining e-mail addresses in backend logs - #1375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1359 masked the trial and lifecycle mails, but the Cloud backend log still had about 1,430 lines with a full e-mail address in the last 23 hours: onboarding reminders (866), social sign-in on the authorize page (~360), dashboard approvals (~170), login warnings and trial licence retries. Addresses are personal data and do not belong in the log.
Changes
loggerline outsideee/that printed an address now printsmaskEmail(...)(ad***@example.com), the helper Mask recipient addresses in the e-mail service logs #1359 already uses: 12 lines insettings/email.service.ts, 7 inauth/login.controller.ts, 3 inauth/auth.controller.ts, 4 inlicense/license.service.ts. Log text only, no behaviour change.email.service.spec.ts; a new test inlogin.controller.spec.tschecks the unknown-user, wrong-password and successful-login lines.Type
Testing
In packages/backend:
npx jest src/settings/email.service.spec.ts src/auth/login.controller.spec.ts src/auth/login.controller.social.spec.ts src/license src/auth/auth.controller(12 suites, 295 passed),npx eslinton the six files,npx tsc --noEmit -p tsconfig.json. Same behaviour in Cloud and self-hosted.Checklist
Related Issues
Follow-up to #1359. Daily check 2026-11-01, cloud.md candidate 1.