Repository navigation
Translate the connector page (DE, IT) - #1325
Merged
helpcodeai merged 2 commits intoOct 29, 2026
Merged
Conversation
Part of HelpCode-ai#1271. First half of the connector detail area: the page itself without the tools section, which follows in the next PR. English output is unchanged.
15 tasks done
helpcodeai
approved these changes
Oct 29, 2026
helpcodeai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sapatmohit, this is a careful one. I checked:
- The changes are text only: every removed English literal from the page is in
en.jsonverbatim, thet→vrenames remove the shadowing, and the only other changes areuseAuthTypeLabelandtoLocaleDateString(locale). connectorDetail(167 keys) anduserCredentials(24) have the same keys and placeholders in all three languages;perUserBodykeeps its ICU select in each.- German and Italian read well and match the earlier PRs: Sie / tu, "Connector" / "connettore", "SAP-Mandant" / "Mandante SAP", "Gesperrte Tabellen" / "Tabelle bloccate". "Leer lassen zum Beibehalten" and "Lascia vuoto per mantenerlo" are fine for the half-width fields.
One optional nit for a later PR, not blocking: as a standalone button, Italian "Testa" can read as the noun ("head"). "Verifica" would be unambiguous, but "Testa la connessione" is already used on the connectors list, so keeping it consistent is fine for now.
I'll bring the branch up to date with main and merge once CI is green. Looking forward to the tools section.
Contributor
|
Merged, thanks @sapatmohit! It's on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifth area of #1271, first half: the connector page (
/connectors/[id]) in German and Italian, without its tools section. No behaviour changes, andAccept-Language: en-USrenders exactly what it rendered before.Splitting the area: like Connectors, connector detail is two PRs. The page is about 2,400 lines and the tool editor another 1,600, so together they would be over 4,000 lines. Both are under #1271 and come one at a time:
components/tool-editor/*andcomponents/tool-annotations-editor.tsx.Changes
app/connectors/[id]/page.tsx:components/user-credentials-card.tsx: the shared or per-user sign-in card and its confirmation dialog. It's used only on this page.messages/{en,de,it}.json: new namespacesconnectorDetailanduserCredentials, with 191 keys each.useAuthTypeLabelfrom Translate the connector list and marketplace (DE, IT) #1303, so it matches the connector cards.en-USthey're unchanged.Left in English on purpose:
sap-client, POST/GET, and the example values in placeholders.Self-hosted vs Cloud: frontend only, with no backend, database or
ee/change.Translations
German and Italian aren't my native languages, so please review those strings. I kept the tone and terms from the earlier PRs: German with Sie, Italian with tu, "Connector" / "connettore", "KI-Client" / "client AI", "API-Schlüssel" / "Chiave API". Strings I'm least sure about:
Type
Testing
3 new tests in
tests/e2e/i18n.spec.ts, with a mocked REST connector using an API key:de-DE: the page renders in German in view mode, the environment variables editor, edit mode (labels and the "keep current" placeholder), the danger zone and the delete dialog.it-IT: the page renders in Italian, including edit mode and the danger zone.en-US: everything stays exactly as before, including the delete dialog text.The key-parity test from #1248 covers the new keys. The existing specs for this page (environment variables, OAuth grant and completion, OAuth 1.0a editing, export/import, catalog update preview) all still pass. I measured the page at 1280 px in German, Italian and English, and none of them overflows.
packages/frontendnpm run lintmain; three setState-in-effect warnings on this page no longer fire, none new)packages/frontendnpx tsc --noEmit -p tsconfig.jsonpackages/frontendnpm run buildpackages/frontendnpm run test:e2eThe backend isn't touched, so I didn't rerun its suite.
Checklist
packages/frontend/AGENTS.mdandnext-env.d.tswere rewritten bynext devlocally and are left out, as AGENTS.md asks.Related Issues
Part of #1271 (Connector detail, first half)