Repository navigation
Let a long auth type truncate on the connector card - #1315
Merged
helpcodeai merged 2 commits intoOct 28, 2026
Merged
Conversation
Without min-w-0 on the Tools/Auth column, a long auth type next to a setup or sign-in pill pushed the pills past the card edge.
helpcodeai
approved these changes
Oct 28, 2026
helpcodeai
left a comment
helpcodeai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sapatmohit. Checked: min-w-0 on the flex parents is the right fix for the truncate, CSS-only change, CI green. Merging.
helpcodeai
enabled auto-merge (squash)
October 28, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1303, as asked there: on a connector card, a long auth type next to a setup or sign-in pill pushed the pills past the card's right edge. The Auth value already had
truncate, but its flex parents had nomin-w-0, so it could never shrink.Changes
app/connectors/page.tsx:min-w-0on the Tools/Auth group and on the Auth column, so a long auth type truncates with an ellipsis and the pills stay on the card.English changes too: "Connection String" and "OAuth 2.0" now truncate ("Connection …", "OAuth …") when a card also shows two pills, because the row was only about 13px from overflowing. Cards with one pill, or a short auth type, look the same as before.
Type
Testing
No new test: the existing i18n tests for
/connectorsalready render these two cards, and still pass, since the truncated text is the same text node.packages/frontendnpm run lintmain)packages/frontendnpx tsc --noEmit -p tsconfig.jsonpackages/frontendnpx playwright test tests/e2e/i18n.spec.ts tests/e2e/connector-export-import.spec.tsChecklist
Related Issues
Follow-up to #1303 (part of #1271)