Skip to content

Fix Printify uploads limit, weclapp comment visibility, Odoo call_method hints - #1311

Merged
helpcodeai merged 3 commits into
mainfrom
fix/adapter-printify-weclapp-odoo
Oct 28, 2026
Merged

helpcodeai merged 3 commits into
mainfrom
fix/adapter-printify-weclapp-odoo

Conversation

@helpcodeai

Copy link
Copy Markdown
Contributor

Summary

Three catalog tools fail on Cloud because their schema or description leads the model to a request the API rejects. Errors are from the last 14 days.

  • printify_list_uploads: the description said up to 100 images per page. Printify answers limit: The limit may not be greater than 50 (code 8150). 21 of 21 calls with limit=100 failed, and all calls at 50 or less succeeded. Now says 1-50, with minimum: 1 and maximum: 50.
  • weclapp_add_comment: privateComment and publicComment both defaulted to false, and weclapp answers "comments have to be either private or public". The 5 errors are exactly the calls that left both false; every success set exactly one. The defaults are gone, and the tool and both flags now say to set exactly one of them.
  • odoo_call_method: 28 errors "missing a required argument: 'vals' / 'vals_list' / 'domain' / 'field_name'", because the model sent the values as loose fields. The kwargs description now says required arguments go under their Odoo parameter name ({"vals": {...}} for write, {"vals_list": [{...}]} for create, {"domain": [...]} for search), and points to odoo_create / odoo_write. The ids description now says to call once per id when a method fails with "Expected singleton".

Changes

  • intl/printify.json, de/weclapp.json, intl/odoo.json: descriptions and schema as above. No tool, path or body mapping changes.
  • Static assertions in the three .live.spec.ts files.

Type

  • Bug fix

Testing

  • Added/updated unit tests

Commands, run from the repo root unless noted:

  • node scripts/validate-adapters.mjs --warn: 574 passed, 0 failed, 1442 warnings (same count as main; none new).
  • node scripts/regenerate-catalog.mjs: no diff.
  • node scripts/adapter-count.mjs --check: OK, 560 adapters.
  • node scripts/generate-llms-txt.mjs --check: up to date.
  • In packages/backend: npx jest src/adapters/intl/printify src/adapters/de/weclapp src/adapters/intl/odoo.live → 5 suites, 58 passed, 3 skipped (live). npx jest src/adapters/catalog → 10,658 passed.

Same behaviour in Cloud and self-hosted. Installed connectors pick the change up through the catalog re-sync.

Checklist

  • My code follows the existing code style
  • I have tested my changes locally
  • This PR has a descriptive title

@helpcodeai
helpcodeai requested a review from D3nisty as a code owner October 28, 2026 08:22
@helpcodeai
helpcodeai enabled auto-merge (squash) October 28, 2026 08:54
@helpcodeai
helpcodeai merged commit c2d16d4 into main Oct 28, 2026
14 checks passed
@helpcodeai
helpcodeai deleted the fix/adapter-printify-weclapp-odoo branch October 28, 2026 09:05
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant