Repository navigation
Translate the MCP server pages (DE, IT) - #1283
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third area of #1271: the MCP server pages (
/mcp-serverand/mcp-server/[id]) in German and Italian, plus theConnectionCheckcard on the server page. It builds on #1272 and #1274. No behaviour changes, andAccept-Language: en-USrenders exactly what it rendered before.Changes
app/mcp-server/page.tsx: the title, the "New MCP Server" button and create form, search and status filter, the empty and no-match states, and each server card (status, "Exposes …", copy button, the connector and API-key counts, and the usage line).app/mcp-server/[id]/page.tsx: everything on the server page.t.richwith<strong>,<code>and<em>so each language can order its own sentences.confirm()dialogs.components/connection-check.tsx: the waiting, connected and "just called" states. This is the first PR that touches it, so it's translated here, as agreed in Translate the rest of the admin UI (DE, IT) #1271.timeAgonow takes a translator (useTranslations('timeAgo')).messages/{en,de,it}.json: new namespacestimeAgo,connectionCheck,mcpServersandmcpServer, with 161 keys each.Two small code changes that keep the English output identical:
"Error". That check fails once the text is translated, so the state is now{ text, error }, set where the message is created.w-[60px]. It's nowmin-w-[60px] whitespace-nowrap, so the Italian "1 strumento" no longer wraps onto two lines. English renders as before.Left in English on purpose:
MCP_AUTH_MODE,MCP_INSPECTOR_API_TOKEN).FirstSuccessOffer, which also appears on this page. It's a Cloud billing card shared with the dashboard, the connectors pages and the trial banner, and its text comes fromlib/first-success-offer.tswith its own unit tests. Like the plan picker and banners I mentioned in Translate the audit log and analytics pages (DE, IT) #1274, I'd handle it with the other billing and shared components rather than here.Self-hosted vs Cloud: frontend only, with no backend, database or
ee/change. The Cloud-only Claude Directory note is translated too.Translations
German and Italian aren't my native languages, so please review those strings. I kept the tone and terms from the earlier PRs: German with Sie, Italian with tu. Counts use real plurals in German and Italian ("1 Connector", "1 strumento"); English keeps its current text ("1 connectors"). Strings I'm least sure about:
/mcp-server/mcp-server/[id]Type
Testing
3 new tests in
tests/e2e/i18n.spec.ts, with a mocked server and connector:de-DE:/mcp-serverrenders in German, including the usage line with plurals ("Zuletzt genutzt vor 2 Tagen · 1 Aufruf in 30 Tagen"), the status pill, "Stellt bereit" and the connector count.it-IT:/mcp-server/[id]renders in Italian, including the assigned connectors title, the connect card, server settings, the waiting connection check, a rich-text line, and the Claude Desktop Quick Connect modal.en-US: both pages stay exactly as before, including the usage line, "Exposes", the connection check, and "Saved" after "Select all".The key-parity test from #1248 covers the new keys. The existing
mcp-server-assignmentsandmcp-server-connect-clientsspecs, which check English text, still pass.packages/frontendnpm run lintmain, none new)packages/frontendnpx tsc --noEmit -p tsconfig.jsonpackages/frontendnpm run buildpackages/frontendnpm run test:e2eThe backend isn't touched, so I didn't rerun its suite.
Checklist
packages/frontend/AGENTS.mdandnext-env.d.tswere rewritten bynext devlocally and are left out, as AGENTS.md asks.Related Issues
Part of #1271 (MCP servers)