fix: a TSpeedButton connected to a TAction, and a TMenuItem were not auto-checking

ansgarbecker · ansgarbecker · commit 42abf46ae3a9 · 2025-12-09T15:44:10.000+01:00
diff --git a/source/main.lfm b/source/main.lfm
@@ -905,7 +905,9 @@ object MainForm: TMainForm
           Top = 0
           Width = 23
           Action = actFavoriteObjectsOnly
+          AllowAllUp = True
           Anchors = [akTop, akRight]
+          GroupIndex = 1
           Images = ImageListMain
           ImageIndex = 113
           ShowCaption = False
@@ -20434,6 +20436,7 @@ object MainForm: TMainForm
         AutoCheck = True
       end
       object menuShowSizeColumn: TMenuItem
+        AutoCheck = True
         Caption = 'Display size of objects'
         OnClick = menuShowSizeColumnClick
       end
diff --git a/source/main.pas b/source/main.pas
@@ -12641,8 +12641,7 @@ procedure TMainForm.CloseQueryTab(PageIndex: Integer);
 procedure TMainForm.actFavoriteObjectsOnlyExecute(Sender: TObject);
 begin
   // Click on "tree favorites" main button
-  // actFavoriteObjectsOnly.AutoCheck does not work?
-  //actFavoriteObjectsOnly.Checked := not actFavoriteObjectsOnly.Checked;
+  // Note: a TSpeedButton connected to an auto-checked TAction needs AllowAllUp + GroupIndex>0
   editDatabaseTableFilterChange(Sender);
   if actFavoriteObjectsOnly.Checked then
     actFavoriteObjectsOnly.ImageIndex := 112
