Skip to content

[pull] master from flutter:master - #9

Merged
pull[bot] merged 6 commits into
Hawthorne001:masterfrom
flutter:master
Jul 16, 2025
Merged

pull[bot] merged 6 commits into
Hawthorne001:masterfrom
flutter:master

Conversation

@pull

@pull pull Bot commented Jul 16, 2025 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.3)

Can you help keep this open source service alive? 💖 Please sponsor : )

engine-flutter-autoroll and others added 6 commits July 16, 2025 13:46
Closes #143396

### Description
- Removes `js_util` library usage across the codebase

In order to get rid of `dart.library.js_util` in
[`kIsWeb`](https://github.com/flutter/flutter/blob/e8d56b25c039666e1040c22ac36cfa3550be58cf/packages/flutter/lib/src/foundation/constants.dart#L83)
constant the dart analyzer has to be updated first. For now, the
`dart.library.js_util` value is hardcoded in the source code:
https://github.com/dart-lang/sdk/blob/1a88edceb75f70490827ef845586bf549d5f05b0/pkg/analyzer/lib/src/dart/constant/evaluation.dart#L2908-L2915.
So we either have to update this value or wait for the
dart-lang/sdk#50045 fix.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
https://skia.googlesource.com/skia.git/+log/59be8479c637..bf3f9b77d3a8

2025-07-16 [email protected] Copy version.js instead of install due to
symlinks
2025-07-16 [email protected] Roll
vulkan-deps from dd4d30b3bfd0 to d28110d62aa4 (5 revisions)
2025-07-16 [email protected] [graphite] Move Android
PrecompileSettings to their own file
2025-07-16 [email protected] [graphite] Allow ClipStack to modify
draw geometry
2025-07-16 [email protected] Fix/diagnose missing bazel paths in
skottie-final
2025-07-16 [email protected] change generatePath() to return
optional<GeneratedPath>
2025-07-16 [email protected] [rust png] Gracefully handle input
stream that shrinks over time (reland).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…h operations) (#172236)

This fixes #172184 by considering
the last commit to `release-candidate-branch.version` as the significant
commit.

Otherwise, operationally, it works the same. I tested this on 3.35 and
it works as expected (where the current does not).
Some changes which make Skwasm less dependent on GC cycles to free its
native resources:
* Explicitly clean up pictures clipped by the scene view
* Free native `ParagraphBuilder` when `build()` is called
* Restructure `TextStyle`, `ParagraphStyle`, `StrutStyle` and
`LineMetrics` so that they don't persistently hang on to native objects
beyond a paragraph build cycle.

This addresses #170889
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro integration_ui_driver"
}
-->
The issue #167638 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20integration_ui_driver%22).
This test can be marked as unflaky.
@pull pull Bot locked and limited conversation to collaborators Jul 16, 2025
@pull pull Bot added the ⤵️ pull label Jul 16, 2025
@pull
pull Bot merged commit b9d2459 into Hawthorne001:master Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants