Repository navigation
[pull] master from flutter:master - #1
Merged
Merged
Conversation
flutter-team-archive/engine@bacc5e1...0a0d5c9 2024-11-01 [email protected] Roll Skia from 6035cb5a879c to 3b50199d27bb (1 revision) (flutter-team-archive/engine#56300) 2024-11-01 [email protected] Roll Skia from 696528fe7d07 to 6035cb5a879c (1 revision) (flutter-team-archive/engine#56299) 2024-11-01 [email protected] Roll Dart SDK from 32bebf22c765 to 09c8281e66cc (1 revision) (flutter-team-archive/engine#56298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@0a0d5c9...3a090b4 2024-11-01 [email protected] fml: Delete weak_nsobject.h,mm (flutter-team-archive/engine#56289) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro service_extensions_test"
}
-->
Issue link: #157852
flutter/packages@7cc1caa...796afa3 2024-11-01 [email protected] [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990) 2024-11-01 [email protected] [various] Minor cleanup in recently imported packages (flutter/packages#7995) 2024-11-01 [email protected] [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997) 2024-10-31 [email protected] Manual roll Flutter from fe71cad to 0fe6153 (18 revisions) (flutter/packages#7989) 2024-10-31 [email protected] [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991) 2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986) 2024-10-31 [email protected] [flutter_svg] Initial import (flutter/packages#7944) 2024-10-31 [email protected] [vector_graphics] Initial import (flutter/packages#7941) 2024-10-30 [email protected] [ci] Ensure repo tool is autoformatted (flutter/packages#7963) 2024-10-30 [email protected] Updates path_parsing README.md with a note about Dan (flutter/packages#7949) 2024-10-30 [email protected] [tool] Support third_party for --current-package (flutter/packages#7967) 2024-10-30 [email protected] [tool] Fix third_party dependency overrides (flutter/packages#7966) 2024-10-30 [email protected] Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822) 2024-10-30 [email protected] [palette_generator] Remove unmanaged code snippet (flutter/packages#7962) 2024-10-30 [email protected] Roll Flutter from 42132e8 to fe71cad (12 revisions) (flutter/packages#7961) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I recommend reviewing with [whitespace changes disabled](https://github.com/flutter/flutter/pull/157971/files?diff=split&w=1). Changes: 1. Replaces `expect(string.contains('foo'), isTrue)` with `expect(string, contains('foo'))` 2. Replaces `try/finally` with `addTearDown` Follow-up to: #157482 (comment)
….configSetting`. (#158013) ... for consistency with the rest of the file/features.
Updates `basic.dart` to use consistent doc snippets that follows the style from the [documentation on snippets](https://github.com/flutter/flutter/tree/master/dev/snippets#snippet-tool). Follow-up to: #157227 (comment)
Reach peak idiomacy by replacing `expect(file.existsSync(), isTrue)` with `expect(file, exists)`! Follow up to: #157971
flutter-team-archive/engine@3a090b4...7b176f4 2024-11-01 [email protected] Roll Skia from 3b50199d27bb to dfbb0e6bc974 (2 revisions) (flutter-team-archive/engine#56305) 2024-11-01 [email protected] Roll Dart SDK from 09c8281e66cc to 789763468d6b (2 revisions) (flutter-team-archive/engine#56303) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@7b176f4...7dfdcac 2024-11-01 [email protected] Reland single threaded Skwasm (flutter-team-archive/engine#56282) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@7dfdcac...38b6165 2024-11-01 [email protected] [Impeller] fix downsample with decal tile mode. (flutter-team-archive/engine#56316) 2024-11-01 [email protected] Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter-team-archive/engine#56320) 2024-11-01 [email protected] Remove superfluous dart2wasm test suites/bundles. (flutter-team-archive/engine#56315) 2024-11-01 [email protected] Write run_tests console logs to stdout instead of stderr (flutter-team-archive/engine#56312) 2024-11-01 [email protected] [impeller] use greater equal rather than greater depth compare. (flutter-team-archive/engine#56310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@38b6165...05cb5d7 2024-11-02 [email protected] Refactor `BuildPlan`, better document and explain `--config`. (flutter-team-archive/engine#56324) 2024-11-01 [email protected] Roll Fuchsia Linux SDK from MjcuejuzYvYGobbFM... to 07KmbdEtnhkg_tUhe... (flutter-team-archive/engine#56322) 2024-11-01 [email protected] [Impeller] implement external texture gl for embedder. (flutter-team-archive/engine#56277) 2024-11-01 [email protected] Roll Dart SDK from 789763468d6b to 61bf0877807e (2 revisions) (flutter-team-archive/engine#56323) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from MjcuejuzYvYG to 07KmbdEtnhkg If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributes to #130459 It adds a test for - `examples/api/lib/widgets/scrollbar/raw_scrollbar.0.dart`
This PR fixes the typos and spelling error in `CHANGELOG.md` file. Fixes #157083
Contributes to #130459 It adds a test for - `examples/api/lib/widgets/interactive_viewer/interactive_viewer.constrained.0.dart`
Contributes to #130459 It adds a test for - `examples/api/lib/widgets/scrollbar/raw_scrollbar.1.dart`
This adds benchmarks that run on single threaded skwasm.
closes #40740 <p align="center"> <img src="https://github.com/user-attachments/assets/8a48abd0-466b-4e06-90f3-dd05869bac27" alt="NestedScrollController fix" height="720px" /> </p> <details> <summary><h4>Demo source code</h4> (click to expand)</summary> (this is a slightly more concise version of the code sample from #40740) ```dart import 'package:flutter/material.dart'; void main() { runApp( const MaterialApp( debugShowCheckedModeBanner: false, home: Scaffold(body: NewsScreen()), ), ); } class NewsScreen extends StatelessWidget { const NewsScreen({super.key}); static const List<String> _tabs = <String>['Featured', 'Popular', 'Latest']; static final List<Widget> _tabViews = <Widget>[ for (final String name in _tabs) SafeArea( top: false, bottom: false, child: Builder(builder: (BuildContext context) { final handle = NestedScrollView.sliverOverlapAbsorberHandleFor(context); return NotificationListener<ScrollNotification>( onNotification: (ScrollNotification notification) => true, child: CustomScrollView( key: PageStorageKey<String>(name), slivers: <Widget>[ SliverOverlapInjector(handle: handle), SliverPadding( padding: const EdgeInsets.all(8.0), sliver: SliverList( delegate: SliverChildBuilderDelegate( childCount: 30, (BuildContext context, int index) => Container( margin: const EdgeInsets.only(bottom: 8), width: double.infinity, height: 150, color: const Color(0xFFB0A4C8), alignment: Alignment.center, child: Text( '$name $index', style: const TextStyle(fontWeight: FontWeight.w600), ), ), ), ), ), ], ), ); }), ), ]; @OverRide Widget build(BuildContext context) { return DefaultTabController( length: _tabs.length, child: NestedScrollView( headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) => <Widget>[ SliverOverlapAbsorber( handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context), sliver: SliverSafeArea( top: false, sliver: SliverAppBar( title: const Text('Tab Demo'), floating: true, pinned: true, snap: true, forceElevated: innerBoxIsScrolled, bottom: TabBar( tabs: _tabs.map((String name) => Tab(text: name)).toList(), ), ), ), ), ], body: TabBarView(children: _tabViews), ), ); } } ``` <br> </details> <br> This bug can be traced to a return statement inside `_NestedScrollPosition`: ```dart double applyClampedDragUpdate(double delta) { // ... return delta + offset; } ``` Thanks to some quirks of floating-point arithmetic, `applyClampedDragUpdate` would sometimes return a tiny non-zero value, which ends up ruining one of the scroll coordinator's equality checks. https://github.com/flutter/flutter/blob/8990ed6538592fc8aee63b0e137b7b52804a030f/packages/flutter/lib/src/widgets/nested_scroll_view.dart#L658-L664
## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
We added `use_modular_headers!` to our `Podfile`s as we originally planned to phase out `use_frameworks!` (see #42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager. CocoaPods's `use_frameworks!` and `use_modular_headers!` are two different overlapping options that should not be used together. This change removes the `use_modular_headers!` from the macOS `Podfile` and the iOS Swift `Podfile` (the iOS Objective-C template was recently deprecated #155867). This change only affects _new_ Flutter apps. This change does not include an automatic migration as that could break existing apps. Instead, users are encouraged to migrate from CocoaPods to Swift Package Manager. #156259
flutter-team-archive/engine@05cb5d7...25c7e47 2024-11-04 [email protected] Retry mac_unopt one time in presubmit (flutter-team-archive/engine#56319) 2024-11-04 [email protected] [Impeller] faster descriptor type mapping. (flutter-team-archive/engine#56351) 2024-11-04 [email protected] Roll Skia from 75740b68a282 to e2ad60ea8039 (8 revisions) (flutter-team-archive/engine#56354) 2024-11-04 [email protected] Move detection of cutouts in Android engine to `onApplyWindowInsets` (flutter-team-archive/engine#55992) 2024-11-04 [email protected] Roll Dart SDK from 69cec5dc51f9 to f238183cf168 (1 revision) (flutter-team-archive/engine#56353) 2024-11-04 [email protected] Roll Skia from bab7d954758b to 75740b68a282 (1 revision) (flutter-team-archive/engine#56349) 2024-11-04 [email protected] Roll Fuchsia Linux SDK from 07KmbdEtnhkg_tUhe... to amgHXcqtplha8LuI_... (flutter-team-archive/engine#56348) 2024-11-03 [email protected] Roll Skia from 6944cd128603 to bab7d954758b (2 revisions) (flutter-team-archive/engine#56346) 2024-11-02 [email protected] Roll Dart SDK from 61bf0877807e to 69cec5dc51f9 (2 revisions) (flutter-team-archive/engine#56335) 2024-11-02 [email protected] Multiple touches of a stylus should be considered from the same device (flutter-team-archive/engine#56075) 2024-11-02 [email protected] Roll Skia from 89ac72bb4922 to 6944cd128603 (2 revisions) (flutter-team-archive/engine#56331) 2024-11-02 [email protected] [web] Transfer focus to view rootElement on blur/remove. (flutter-team-archive/engine#55045) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 07KmbdEtnhkg to amgHXcqtplha If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@25c7e47...f880b56 2024-11-04 [email protected] Made it so angle builds on linux (flutter-team-archive/engine#56328) 2024-11-04 [email protected] [Impeller] combine translate* scale mat mul when computing shader transform. (flutter-team-archive/engine#56352) 2024-11-04 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter-team-archive/engine#56191) 2024-11-04 [email protected] iOS: Eliminate fml::scoped_nsobject pointer use (flutter-team-archive/engine#56295) 2024-11-04 [email protected] Roll Skia from e2ad60ea8039 to b2bb3af36da3 (1 revision) (flutter-team-archive/engine#56355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changes: - Remove 2<sup>nd</sup> person language from docs ([relevant style guideline](https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-the-passive-voice-recommend-do-not-require-never-say-things-are-simple)) - Update a bunch of spots to be more explicit about `WidgetStateMouseCursor`. - `WidgetStateFoo` constructors now accurately describe what happens when used incorrectly. - Gave `WidgetStateProperty` a little section about equality checks.
flutter-team-archive/engine@f880b56...75accee 2024-11-04 [email protected] Roll Dart SDK from f238183cf168 to 0addd35215d0 (1 revision) (flutter-team-archive/engine#56357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
After the dart build is done, the flutter tool has to bundle the produced shared libraries, which it does that by copying them around. Though the code assumed that all code assets are shared libraries to be bundled, whereas in fact one can have code assets without any actual code (ones that are installed on the target system already or artificial code assets whose symbols get resolved from executable / process). => Using non-bundled code assets currently results in null pointer exceptions and/or cast errors. => We update the copy code to only operate on code assets that have a shared library to bundle. We also update the copy routines by removing copy&past'ed - but slightly different - printing code into the shared caller function.
flutter/packages@b9ac917...b164be3 2024-11-14 [email protected] Remove packages/platform from dependabot config (flutter/packages#8099) 2024-11-14 [email protected] Ignore dependabot minor and patch updates of Kotlin mocking library (flutter/packages#8056) 2024-11-14 [email protected] [google_identity_services_web] Set nonce properly in loadWebSdk(). (flutter/packages#8069) 2024-11-14 [email protected] Roll Flutter (stable) from 6031040 to dec2ee5 (4 revisions) (flutter/packages#8084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
As the title says, this PR deletes the HTML renderer's benchmarks.
…build apk` health tests time out more often? (#158967)" (#158993) Reverts: #158967 Initiated by: matanlurey Reason for reverting: `--run-skipped` doesn't work in this repository (#158972). Original PR Author: matanlurey Reviewed By: {andrewkolos} This change reverts the following previous change: I have no idea if this will work, but `6_6` is currently the suite that seems to have the most problems. Towards #158560.
Currently the `NativeAsset` target in flutter tools is responsible for two things: * performing the dart build (in the app as well as all transitive pub dependencies) * taking output (shared libraries) from this build and copying them around This intermingling of responsibilities leads to more complex code and potentially unnecessary work: If the source code changed (e.g. `.c` files change) we have to run the dart build again. But doing so may result in the same shared libraries (e.g. adding comments to the `.c` code). Currently we're going to copy the shared libraries despite them having not changed, which then may cause upstream things to be dirtied (if it's based on timestamp of files) and re-built. Instead this PR splits this `NativeAsset` into the two orthogonal pieces * `DartBuild` target that is responsible for the dart build * `InstallCodeAssets` that is responsible for copying shared libraries to the right place and producing a `native_assets.yaml`. This decoupling is also preparation for a future where a dart build can produce other kinds of assets (e.g. data assets) and is used in the web build as well. (The web build would use `DartBuild` but not `InstalCodeAssets`).
Mostly just testing the MQ functionality
## Description This makes the `focusNode` for `SelectableRegion` optional so that: - Users of the widget are no longer required to use `SelectableRegion` from within a `StatefulWidget` - They aren't likely to forget to dispose of a node they didn't supply. - Simpler to use, and the node is not used very often anyhow. Also made the `SelectableRegion` sample actually use `SelectableRegion`. ## Tests - Modified all the `SelectableRegion` tests to remove 3 identical lines of boilerplate from each (except 2, which actually used their focus nodes).
…sts. (#159004) Towards #159000 as part of debugging issues such as #158560. On a `bringup: true` shard, run a number of `flutter build apk` tests in succession to try and routinely trigger timeouts and crashes, so we can test other hypotheses on how to fix this problem (i.e. potentially around increasing memory, changing daemon configuration, aggressively killing processes, etc).
Update list of frequent web contributors
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows windows_desktop_impeller"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20windows_desktop_impeller%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux web_benchmarks_skwasm_st"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20web_benchmarks_skwasm_st%22).
This test can be marked as unflaky.
Co-authored-by: Jackson Gardner <[email protected]>
Roll Flutter Engine from 619804c to f649330 (47 revisions) flutter-team-archive/engine@619804c...f649330 2024-11-16 [email protected] Roll Skia from 1ef3b910e064 to 6b0f264bde33 (6 revisions) (flutter-team-archive/engine#56635) 2024-11-16 [email protected] Revert "Remove `android_jit_release_x86`." (flutter-team-archive/engine#56634) 2024-11-15 [email protected] Move SetRenderTargetType to EmbedderTestCompositor (flutter-team-archive/engine#56626) 2024-11-15 [email protected] Roll Dart SDK from b62dadb14d82 to eccb15756020 (2 revisions) (flutter-team-archive/engine#56630) 2024-11-15 [email protected] [TextInput] Add TextInputType.webSearch (#15762) (flutter-team-archive/engine#56428) 2024-11-15 [email protected] [web] Send the correct view ID with semantics actions (flutter-team-archive/engine#56595) 2024-11-15 [email protected] [macos] early return to suppress clang-tidy warning (flutter-team-archive/engine#56588) 2024-11-15 [email protected] [Impeller] libImpeller: Tinker on the README to cross reference the SDK and the example. (flutter-team-archive/engine#56623) 2024-11-15 [email protected] [fuchsia] MaybeRunInitialVsyncCallback should only called once (flutter-team-archive/engine#56429) 2024-11-15 [email protected] Move mac clangd build from x64 to arm (flutter-team-archive/engine#56567) 2024-11-15 [email protected] Added assert for opengles thread safety (flutter-team-archive/engine#56585) 2024-11-15 [email protected] [Impeller] enable OpenGL fallback on Android. (flutter-team-archive/engine#56591) 2024-11-15 [email protected] [Impeller] Maintain separate queues of GLES operations for each thread in the reactor (flutter-team-archive/engine#56573) 2024-11-15 [email protected] Roll Dart SDK from abe86ca4eb01 to b62dadb14d82 (2 revisions) (flutter-team-archive/engine#56615) 2024-11-15 [email protected] Roll Skia from b730eb340852 to 1ef3b910e064 (4 revisions) (flutter-team-archive/engine#56613) 2024-11-15 [email protected] Roll Fuchsia Linux SDK from JkpuAsLzcmYLzf1iX... to UpSQzyXGUhMfedYIh... (flutter-team-archive/engine#56611) 2024-11-15 [email protected] Roll Dart SDK from bf0eeb9d929c to abe86ca4eb01 (1 revision) (flutter-team-archive/engine#56610) 2024-11-15 [email protected] Roll Skia from e5fda8472b21 to b730eb340852 (1 revision) (flutter-team-archive/engine#56608) 2024-11-15 [email protected] Roll Skia from 8ff65da4b8bf to e5fda8472b21 (1 revision) (flutter-team-archive/engine#56603) 2024-11-15 [email protected] Move TestMetalContext/Surface to testing namespace (flutter-team-archive/engine#56602) 2024-11-15 [email protected] Roll Dart SDK from 343b9fc6eafe to bf0eeb9d929c (1 revision) (flutter-team-archive/engine#56604) 2024-11-15 [email protected] [Impeller] Don't enable KHR_debug on Angle. (flutter-team-archive/engine#56601) 2024-11-15 [email protected] [Impeller] libImpeller: Reset the GL state when transitioning control back to the embedder. (flutter-team-archive/engine#56597) 2024-11-15 [email protected] Roll Skia from 8946ea477b42 to 8ff65da4b8bf (2 revisions) (flutter-team-archive/engine#56600) 2024-11-14 [email protected] [Impeller] Put test components in the testing namespace. (flutter-team-archive/engine#56594) 2024-11-14 [email protected] [Impeller] libImpeller: Add a warning about OpenGL state being trampled. (flutter-team-archive/engine#56599) 2024-11-14 [email protected] Embedder: Refactor EmbedderConfigBuilder by backend (flutter-team-archive/engine#56598) 2024-11-14 [email protected] Migrate Metal translation units to Obj-C++ (flutter-team-archive/engine#56592) 2024-11-14 [email protected] Roll Dart SDK from db4d7d52db48 to 343b9fc6eafe (1 revision) (flutter-team-archive/engine#56590) 2024-11-14 [email protected] iOS,macOS: Build/test test_metal_surface_unittests (flutter-team-archive/engine#56586) 2024-11-14 [email protected] Roll Skia from 3222456e63dc to 8946ea477b42 (2 revisions) (flutter-team-archive/engine#56587) 2024-11-14 [email protected] Roll Skia from 16178bf63de7 to 3222456e63dc (3 revisions) (flutter-team-archive/engine#56584) 2024-11-14 [email protected] [Android] Fix Slider semantics double tap behaviors (flutter-team-archive/engine#56452) 2024-11-14 [email protected] Roll Dart SDK from a3b6652100c8 to db4d7d52db48 (1 revision) (flutter-team-archive/engine#56581) 2024-11-14 [email protected] Move Vulkan context to EmbedderTestContextVulkan (flutter-team-archive/engine#56571) 2024-11-14 [email protected] Roll Skia from a076435073fc to 16178bf63de7 (1 revision) (flutter-team-archive/engine#56579) 2024-11-14 [email protected] Roll Skia from 70553189e4e8 to a076435073fc (1 revision) (flutter-team-archive/engine#56577) 2024-11-14 [email protected] Roll Skia from fa52f2c1ddba to 70553189e4e8 (1 revision) (flutter-team-archive/engine#56576) 2024-11-14 [email protected] Roll Dart SDK from 3f05b3540cb2 to a3b6652100c8 (3 revisions) (flutter-team-archive/engine#56575) 2024-11-14 [email protected] Roll Skia from ddbd8d1cb8d8 to fa52f2c1ddba (3 revisions) (flutter-team-archive/engine#56574) 2024-11-14 [email protected] [Android] choose 24 bit depth buffer. (flutter-team-archive/engine#56553) 2024-11-14 [email protected] Roll Skia from 3750b8939c7f to ddbd8d1cb8d8 (1 revision) (flutter-team-archive/engine#56562) 2024-11-14 [email protected] Move FlMouseCursorHandler from FlView to FlEngine (flutter-team-archive/engine#56026) 2024-11-14 [email protected] [Impeller] force software resize usage for GLES backend. (flutter-team-archive/engine#56511) 2024-11-14 [email protected] Roll Dart SDK from 66ab1774bfe9 to 3f05b3540cb2 (2 revisions) (flutter-team-archive/engine#56564) 2024-11-14 [email protected] Embedder: Refactor EmbedderTestContext creation (flutter-team-archive/engine#56563) ...
flutter-team-archive/engine@f649330...f238321 2024-11-16 [email protected] Roll Dart SDK from eccb15756020 to 77a4ee3266a4 (1 revision) (flutter-team-archive/engine#56640) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@f238321...98c3b7f 2024-11-16 [email protected] Backend-specific EmbedderTestBackingStoreProducers (flutter-team-archive/engine#56638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@98c3b7f...1800193 2024-11-16 [email protected] Roll Fuchsia Test Scripts from 6FgM4KTbxxmyYoiOs... to OA7UxNZkbxCRfr80A... (flutter-team-archive/engine#56643) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-team-archive/engine@1800193...85d445e 2024-11-16 [email protected] Roll Dart SDK from 77a4ee3266a4 to d47c22e5f63a (1 revision) (flutter-team-archive/engine#56644) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
pull Bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
…er#172783)" (flutter#172900) <!-- start_original_pr_link --> Reverts: flutter#172783 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jtmcdole <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Failing in post submit tests: ``` ╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════ ║ UNEXPECTED ERROR! ║ Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dartvm ║ #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:198:9) ║ <asynchron <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: a-siva <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jason-simmons} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: https://dart.googlesource.com/sdk.git/+log/5ede85aff798..14ea8d342149 https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-36.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-35.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-34.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-33.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-32.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-31.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-30.0.dev https://dart.googlesource.com/sdk.git/+/refs/tags/3.10.0-29.0.dev <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
pull Bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
When building https://github.com/flutter/samples/tree/main/add_to_app/multiple_flutters, the `[CP-User] Run Flutter Build multiple_flutters_module Script` step failed with: ``` Showing Recent Messages [ +3 ms] Improperly formatted define flag: [ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:34:3) #1 AssembleCommand._parseDefines (package:flutter_tools/src/commands/assemble.dart:279:9) ``` the command was: ``` /Users/<User>/flutter/bin/flutter --verbose assemble --no-version-check --output=/Users/<User>/Library/Developer/Xcode/DerivedData/MultipleFluttersIos-<Hash>/Build/Products/Debug-iphonesimulator/ -dTargetPlatform=ios -dTargetFile=lib/main.dart -dBuildMode=debug -dConfiguration=Debug -dIosArchs=arm64 -dSdkRoot=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator26.0.sdk -dSplitDebugInfo= -dTreeShakeIcons=false -dTrackWidgetCreation=true -dDartObfuscation=false -dAction=build -dFrontendServerStarterPath= --ExtraGenSnapshotOptions= --DartDefines= --ExtraFrontEndOptions= -dSrcRoot=/Users/<User>/flutter_debug/samples/add_to_app/multiple_flutters/multiple_flutters_ios -dTargetDeviceOSVersion=26.0 -dCodesignIdentity=- debug_ios_bundle_flutter_assets ``` the empty `--DartDefines=` comes from https://github.com/flutter/flutter/blob/68cddc9bf5c449d5a55fe48ebb9b446ef76ae6b0/packages/flutter_tools/bin/xcode_backend.dart#L660 This PR makes `_parseDefines` ignore these empty dart defines. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
pull Bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
This test passes when run locally as instructed in the README for the devicelab ``` ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t android_verified_input_test ``` but fails on CI: https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20android_verified_input_test/106/overview ``` [2025-11-03 11:08:04.090018] [STDOUT] stdout: [ ] Original error: ext.flutter.driver: (-32000) Service connection disposed [2025-11-03 11:08:04.090156] [STDOUT] stdout: [ ] Original stack trace: [2025-11-03 11:08:04.090199] [STDOUT] stdout: [ ] #0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:268:34) [2025-11-03 11:08:04.091572] [STDOUT] stdout: [ ] #1 VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1950:25) [2025-11-03 11:08:04.091647] [STDOUT] stdout: [ ] #2 VmService._call (package:vm_service/src/vm_service.dart:1962:8) [2025-11-03 11:08:04.091674] [STDOUT] stdout: [ ] #3 VmService.callServiceExtension (package:vm_service/src/vm_service.dart:1901:14) [2025-11-03 11:08:04.091693] [STDOUT] stdout: [ ] #4 VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:327:12) [2025-11-03 11:08:04.091713] [STDOUT] stdout: [ ] #5 FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:573:13) [2025-11-03 11:08:04.091733] [STDOUT] stdout: [ ] #6 main.<anonymous closure> (file:///opt/s/w/ir/x/w/rc/tmpv6pcbna2/flutter%20sdk/dev/integration_tests/android_verified_input/test_driver/main_test.dart:28:57) [2025-11-03 11:08:04.091750] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.091767] [STDOUT] stdout: [ ] #7 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:242:9) [2025-11-03 11:08:04.091784] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092408] [STDOUT] stdout: [ ] #8 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:240:7) [2025-11-03 11:08:04.092472] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092502] [STDOUT] stdout: [ ] #9 Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:282:9) ``` Try copying this configuration used by other tests as a speculative fix. I can't get this test to kick off in presubmit, so I suppose we will just try this. The test is marked bringup anyways so it won't block the tree if this doesn't help. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>
pull Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Relands https://github.com/flutter/flutter/pull/180573 with gradle
lockfiles updated.
Also contains a test fix by Gemini for a failure encountered on
[CI](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8683917112243416113/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_2_5/stdout).
<details>
<summary>Encountered Failure</summary>
00:18 +2 -1: test/integration.shard/test_test.dart: flutter test should
run a test when its name contains a string when
--experimental-faster-testing is set [E]
Expected: a process with exit code 0 and stdout: "RegExp: pattern=\+\d+:
All tests passed! flags="
Actual: <Instance of 'ProcessResult'>
Which: Actual exitCode was 1
Actual stdout:
00:00 +0: loading
/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/trivial_test.dart
[ERROR:flutter/shell/testing/tester_main.cc(622)] Unhandled exception
Exception:
'file:///Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/build/isolate_spawning_tester/child_test_isolate_spawner.dart':
error:
build/isolate_spawning_tester/child_test_isolate_spawner.dart:142:30:
Error: Too many positional arguments: 3 allowed, but 4 found.
Try removing the extra positional arguments.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test.main);
^
Stack trace: #0 main
(file:///Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/build/isolate_spawning_tester/root_test_isolate_spawner.dart:85:55)
#1 _runMain.<anonymous closure> (dart:ui/hooks.dart:430:23)
#2 _delayEntrypointInvocation.<anonymous closure>
(dart:isolate-patch/isolate_patch.dart:313:19)
#3 _RawReceivePort._handleMessage
(dart:isolate-patch/isolate_patch.dart:192:12)
Actual stderr:
build/isolate_spawning_tester/child_test_isolate_spawner.dart:25:266:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:26:277:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:27:279:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:28:269:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:29:281:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:30:274:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:31:277:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:32:263:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:33:261:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:34:272:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:35:261:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:36:262:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:142:294:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:144:305:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:146:307:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:148:297:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:150:309:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:152:302:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:154:305:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:156:291:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:158:289:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:160:300:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:162:289:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:164:290:
Error: Digit separators ('_') in a number literal can only be placed
between two digits.
Try removing the '_'.
createChannelAndConnect('/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart',
route,
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test.main);
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:25:157:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:25:265:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:25:266:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:25:272:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ad_containers_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ad_containers_test;
^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:26:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:26:168:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:26:276:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:26:277:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:26:283:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_codec_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_codec_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:27:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:27:170:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:27:278:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:27:279:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:27:285:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/user_messaging_channel_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_user_messaging_channel_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:28:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:28:160:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:28:268:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:28:269:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:28:275:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:29:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:29:172:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:29:280:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:29:281:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:29:287:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_information_impl_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:30:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:30:165:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:30:273:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:30:274:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:30:280:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_ump_consent_form_impl_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:31:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:31:168:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:31:276:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:31:277:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:31:283:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/rewarded_interstitial_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_rewarded_interstitial_ad_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:32:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:32:154:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:32:262:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:32:263:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:32:269:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_mobile_ads_test;
^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:33:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:33:152:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:33:260:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:33:261:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:33:267:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/fluid_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_fluid_ad_test;
^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:34:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:34:163:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:34:271:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:34:272:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:34:278:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/admanager_banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_admanager_banner_ad_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:35:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:35:152:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:35:260:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:35:261:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:35:267:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/app_open_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_app_open_test;
^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:36:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:36:153:
Error: Expected ';' after this.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:36:261:
Error: Expected a declaration, but got '-'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test;
^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:36:262:
Error: Expected a declaration, but got '8_0_0_'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:36:268:
Error: Variables must be declared using the keywords 'const', 'final',
'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/banner_ad_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_build_ios_SourcePackages_google_mobile_ads-8_0_0_test_banner_ad_test;
^^^^^^^^^^^^^^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:37:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/trivial_widget_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_trivial_widget_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:38:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/print_correct_local_widget_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_print_correct_local_widget_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:39:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/child_directory/trivial_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_child_directory_trivial_test;
^^^^^^
build/isolate_spawning_tester/child_test_isolate_spawner.dart:40:1:
Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import
'/Volumes/Work/s/w/ir/x/w/flutter/dev/automated_tests/flutter_test/child_directory/second_trivial_test.dart'
as
_Volumes_Work_s_w_ir_x_w_flutter_dev_automated_tests_flutter_test_child_directory_second_trivial_test;
^^^^^^
Error: Couldn't resolve the package 'mockito' in
'package:mockito/annotations.dart'.
Error: Couldn't resolve the package 'mockito' in
'package:mockito/mockito.dart'.
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart:22:8:
Error: Not found: 'package:mockito/annotations.dart'
import 'package:mockito/annotations.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart:21:8:
Error: Not found: 'package:mockito/annotations.dart'
import 'package:mockito/annotations.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart:21:8:
Error: Not found: 'package:mockito/annotations.dart'
import 'package:mockito/annotations.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart:25:8:
Error: Not found: 'package:mockito/annotations.dart'
import 'package:mockito/annotations.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.dart:23:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.dart:22:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.dart:22:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.dart:26:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart';
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.mocks.dart:14:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart' as _i1;
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.mocks.dart:14:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart' as _i1;
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.mocks.dart:14:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart' as _i1;
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:17:8:
Error: Not found: 'package:mockito/mockito.dart'
import 'package:mockito/mockito.dart' as _i1;
^
Error: Couldn't resolve the package 'mockito' in
'package:mockito/src/dummies.dart'.
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:18:8:
Error: Not found: 'package:mockito/src/dummies.dart'
import 'package:mockito/src/dummies.dart' as _i14;
^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_test.mocks.dart:32:40:
Error: Type '_i1.Mock' not found.
class MockUserMessagingChannel extends _i1.Mock
^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_information_impl_test.mocks.dart:32:40:
Error: Type '_i1.Mock' not found.
class MockUserMessagingChannel extends _i1.Mock
^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/ump/consent_form_impl_test.mocks.dart:32:40:
Error: Type '_i1.Mock' not found.
class MockUserMessagingChannel extends _i1.Mock
^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:37:48:
Error: Type '_i1.SmartFake' not found.
class _FakePlatformWebViewController_0 extends _i1.SmartFake
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:43:29:
Error: Type '_i1.SmartFake' not found.
class _FakeObject_1 extends _i1.SmartFake implements Object {
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:48:29:
Error: Type '_i1.SmartFake' not found.
class _FakeOffset_2 extends _i1.SmartFake implements _i3.Offset {
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:53:36:
Error: Type '_i1.SmartFake' not found.
class _FakeMethodChannel_3 extends _i1.SmartFake implements
_i4.MethodChannel {
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:58:44:
Error: Type '_i1.SmartFake' not found.
class _FakeWebViewControllerUtil_4 extends _i1.SmartFake
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:64:43:
Error: Type '_i1.SmartFake' not found.
class _FakeInitializationStatus_5 extends _i1.SmartFake
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:70:43:
Error: Type '_i1.SmartFake' not found.
class _FakeRequestConfiguration_6 extends _i1.SmartFake
^^^^^^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:79:37:
Error: Type '_i1.Mock' not found.
class MockWebViewController extends _i1.Mock implements
_i8.WebViewController {
^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:417:37:
Error: Type '_i1.Mock' not found.
class MockAdInstanceManager extends _i1.Mock implements
_i12.AdInstanceManager {
^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:741:41:
Error: Type '_i1.Mock' not found.
class MockWebViewControllerUtil extends _i1.Mock
^^^^^^^^
flutter_test/build/ios/SourcePackages/google_mobile_ads-8.0.0/test/mobile_ads_test.mocks.dart:37:7:
Error: The non-abstract class '_FakePlatformWebViewController_0' is
missing implementations for these members:
- PlatformWebViewController.addJavaScriptChannel
- PlatformWebViewController.canGoBack
- PlatformWebViewController.canGoForward
- PlatformWebViewController.clearCache
- PlatformWebViewController.clearLocalStorage
- PlatformWebViewController.currentUrl
- PlatformWebViewController.enableZoom
- PlatformWebViewController.getScrollPosition
- PlatformWebViewController.getTitle
- PlatformWebViewController.getUserAgent
- PlatformWebViewController.goBack
- PlatformWebViewController.goForward
- PlatformWebViewController.loadFile
- PlatformWebViewController.loadFileWithParams
- PlatformWebViewController.loadFlutterAsset
- PlatformWebViewController.loadHtmlString
- PlatformWebViewController.loadRequest
- PlatformWebViewController.params
- PlatformWebViewController.reload
- PlatformWebViewController.removeJavaScriptChannel
- PlatformWebViewController.runJavaScript
- PlatformWebViewController.runJavaScriptReturningResult
- PlatformWebViewController.scrollBy
- PlatformWebViewController.scrollTo
- PlatformWebViewController.setBackgroundColor
- PlatformWebViewController.setHorizontalScrollBarEnabled
- PlatformWebViewController.setJavaScriptMode
- PlatformWebViewController.setOnConsoleMessage
- PlatformWebViewController.setOnJavaScriptAlertDialog
- PlatformWebViewController.setOnJavaScriptConfirmDialog
- PlatformWebViewController.setOnJavaScriptTextInputDialog
- PlatformWebViewController.setOnPlatformPermissionRequest
- PlatformWebViewController.setOnScrollPositionChange
- PlatformWebViewController.setOverScrollMode
- PlatformWebViewController.setPlatformNavigationDelegate
- PlatformWebViewController.setUserAgent
- PlatformWebViewController.setVerticalScrollBarEnabled
- PlatformWebViewController.supportsSetScrollBarsEnabled
Try to either
- provide an implementation,
- inherit an implementation from a superclass or mixin,
- mark the class as abstract, or
- provide a 'noSuchMethod' implementation.
class _FakePlatformWebViewController_0 extends _i1.SmartFake
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:214:16:
Context: 'PlatformWebViewController.addJavaScriptChannel' is defined
here.
Future<void> addJavaScriptChannel(
^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:125:16:
Context: 'PlatformWebViewController.canGoBack' is defined here.
Future<bool> canGoBack() {
^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:132:16:
Context: 'PlatformWebViewController.canGoForward' is defined here.
Future<bool> canGoForward() {
^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:170:16:
Context: 'PlatformWebViewController.clearCache' is defined here.
Future<void> clearCache() {
^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:177:16:
Context: 'PlatformWebViewController.clearLocalStorage' is defined here.
Future<void> clearLocalStorage() {
^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:118:19:
Context: 'PlatformWebViewController.currentUrl' is defined here.
Future<String?> currentUrl() {
^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:290:16:
Context: 'PlatformWebViewController.enableZoom' is defined here.
Future<void> enableZoom(bool enabled) {
^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:283:18:
Context: 'PlatformWebViewController.getScrollPosition' is defined here.
Future<Offset> getScrollPosition() {
^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:234:19:
Context: 'PlatformWebViewController.getTitle' is defined here.
Future<String?> getTitle() {
^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:328:19:
Context: 'PlatformWebViewController.getUserAgent' is defined here.
Future<String?> getUserAgent() {
^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:141:16:
Context: 'PlatformWebViewController.goBack' is defined here.
Future<void> goBack() {
^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:150:16:
Context: 'PlatformWebViewController.goForward' is defined here.
Future<void> goForward() {
^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:59:16:
Context: 'PlatformWebViewController.loadFile' is defined here.
Future<void> loadFile(String absoluteFilePath) {
^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:73:16:
Context: 'PlatformWebViewController.loadFileWithParams' is defined here.
Future<void> loadFileWithParams(LoadFileParams params) {
^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:81:16:
Context: 'PlatformWebViewController.loadFlutterAsset' is defined here.
Future<void> loadFlutterAsset(String key) {
^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:91:16:
Context: 'PlatformWebViewController.loadHtmlString' is defined here.
Future<void> loadHtmlString(String html, {String? baseUrl}) {
^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:109:16:
Context: 'PlatformWebViewController.loadRequest' is defined here.
Future<void> loadRequest(LoadRequestParams params) {
^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:50:49:
Context: 'PlatformWebViewController.params' is defined here.
final PlatformWebViewControllerCreationParams params;
^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:157:16:
Context: 'PlatformWebViewController.reload' is defined here.
Future<void> reload() {
^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:227:16:
Context: 'PlatformWebViewController.removeJavaScriptChannel' is defined
here.
Future<void> removeJavaScriptChannel(String javaScriptChannelName) {
^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:196:16:
Context: 'PlatformWebViewController.runJavaScript' is defined here.
Future<void> runJavaScript(String javaScript) {
^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:207:18:
Context: 'PlatformWebViewController.runJavaScriptReturningResult' is
defined here.
Future<Object> runJavaScriptReturningResult(String javaScript) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:252:16:
Context: 'PlatformWebViewController.scrollBy' is defined here.
Future<void> scrollBy(int x, int y) {
^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:243:16:
Context: 'PlatformWebViewController.scrollTo' is defined here.
Future<void> scrollTo(int x, int y) {
^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:297:16:
Context: 'PlatformWebViewController.setBackgroundColor' is defined here.
Future<void> setBackgroundColor(Color color) {
^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:266:16:
Context: 'PlatformWebViewController.setHorizontalScrollBarEnabled' is
defined here.
Future<void> setHorizontalScrollBarEnabled(bool enabled) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:304:16:
Context: 'PlatformWebViewController.setJavaScriptMode' is defined here.
Future<void> setJavaScriptMode(JavaScriptMode javaScriptMode) {
^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:336:16:
Context: 'PlatformWebViewController.setOnConsoleMessage' is defined
here.
Future<void> setOnConsoleMessage(
^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:356:16:
Context: 'PlatformWebViewController.setOnJavaScriptAlertDialog' is
defined here.
Future<void> setOnJavaScriptAlertDialog(
^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:367:16:
Context: 'PlatformWebViewController.setOnJavaScriptConfirmDialog' is
defined here.
Future<void> setOnJavaScriptConfirmDialog(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:378:16:
Context: 'PlatformWebViewController.setOnJavaScriptTextInputDialog' is
defined here.
Future<void> setOnJavaScriptTextInputDialog(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:319:16:
Context: 'PlatformWebViewController.setOnPlatformPermissionRequest' is
defined here.
Future<void> setOnPlatformPermissionRequest(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:345:16:
Context: 'PlatformWebViewController.setOnScrollPositionChange' is
defined here.
Future<void> setOnScrollPositionChange(
^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:388:16:
Context: 'PlatformWebViewController.setOverScrollMode' is defined here.
Future<void> setOverScrollMode(WebViewOverScrollMode mode) async {
^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:185:16:
Context: 'PlatformWebViewController.setPlatformNavigationDelegate' is
defined here.
Future<void> setPlatformNavigationDelegate(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:311:16:
Context: 'PlatformWebViewController.setUserAgent' is defined here.
Future<void> setUserAgent(String? userAgent) {
^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dev/webview_flutter_platform_interface-2.15.1/lib/src/platform_webview_controller.dart:259:16:
Context: 'PlatformWebViewController.setVerticalScrollBarEnabled' is
defined here.
Future<void> setVerticalScrollBarEnabled(bool enabled) {
…
pull Bot
pushed a commit
that referenced
this pull request
May 20, 2026
This patch: 1. Updates the `-mios-simulator-version-min` ldflag to `15.0` (this fixes the crash during test discovery). 2. refactors swiftc.py a bit, moves the target triplet logic from darwin/BUILD.gn to swiftc.py so you can override the ios version in a test target (but it's not absolutely necessary for this change since it's the linker flag that makes the difference). 3. Migrates a few xctest tests to swift testing tests. The names of the tests are kept as-is so the diff is easier to read. ### The Crash ``` (lldb) bt * thread #9, name = '[Swift Testing] test discovery - loading test #0 (Task 3)', queue = 'com.apple.root.user-initiated-qos.cooperative', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) * frame #0: 0x0000000000000000 frame #1: 0x000000010ad0fb80 libios_test_flutter.dylib`closure #1() in variable initialization expression of static AccessibilityFeaturesTests.$s22ios_test_flutter_swift26AccessibilityFeaturesTestsV43accessibilityFeatureFlagRawValuesAreCorrect4TestfMp_24accessorc8120add5c86a9e3fMu_ at @__swiftmacro_22ios_test_flutter_swift26AccessibilityFeaturesTestsV43accessibilityFeatureFlagRawValuesAreCorrect4TestfMp_.swift:0 frame #2: 0x000000010224a39c Testing`partial apply for closure #1 in __checkClosureCall(performing:throws:mismatchExplanation:expression:comments:isRequired:sourceLocation:) frame #3: 0x000000010224a39c Testing`partial apply for closure #1 in __checkClosureCall(performing:throws:mismatchExplanation:expression:comments:isRequired:sourceLocation:) frame #4: 0x00000001022d8de8 Testing`(1) await resume partial function for generic specialization <(Testing.Test, Testing.Runner.Plan.Action)> of reabstraction thunk helper <τ_0_0 where τ_0_0: Swift.Sendable> from @escaping @isolated(any) @callee_guaranteed @async () -> (@out τ_0_0) to @escaping @callee_guaranteed @async () -> (@out τ_0_0, @error @owned Swift.Error) frame #5: 0x000000010224ae24 Testing`closure #1 in __checkClosureCall(throws:performing:expression:comments:isRequired:sourceLocation:) ``` Initially I thought swift testing doesn't support test discovery in linked dylibs but it's apparently not the case. And according to gemini it's not anything else in a binary but ``` Load command 9 cmd LC_BUILD_VERSION platform 7 - minos 14.0 + minos 15.6 sdk 26.4 ``` As it tried to use `15.6` in `swift_flags` and put `14.0` in `ldflags` and hit the same crash. This is what gemini has to say: > This is the definitive end of the road! 🔬 > > I have mathematically eliminated every other variable in computing existence. Between a binary that crashes and a binary that runs, literally NOTHING changed except that single number. Also it thinks it's because of this in `dyld`: > Look at the code in dyldMain.cpp at Line 430: > > cpp > // dyldMain.cpp Line 430 > // TODO: Remove once drop support for simulators older than iOS 17, tvOS 15, and watchOS 8 > mach_o::PlatformAndVersions pvs = dyldSimHdr->platformAndVersions(); > mach_o::Policy policy(mach_o::Architecture(), pvs, 0); > // [!!] THE SMOKING GUN [!!] > // Old simulators add the main executable to all_image_info in the simulator process, not in the host > if ( policy.enforceImageListRemoveMainExecutable() ) { > STACK_ALLOC_ARRAY(const mach_header*, mhs, 1); > mhs.push_back(state.config.process.mainExecutableMF); > std::span<const mach_header*> mhSpan(&mhs[0], 1); > > // LITERALLY REMOVES THE IMAGE FROM THE TRACKING TABLE!! > state.externallyViewable->removeImages(state.persistentAllocator, ephemeralAllocator, mhSpan); > } > Why this triggers your exact crash: > The Condition: policy.enforceImageListRemoveMainExecutable() explicitly returns true for all binaries linked below a specific epoch (iOS 15/16). > The Destructive Action: Because dyld thinks it needs to work around an ancient Simulator bug, it explicitly calls removeImages, ripping your binary's tracking data directly out of the global tracking table (all_image_info). > The Crash: Modern Swift Testing and the Swift Runtime rely on scanning all_image_info to discover where the @test sections are in memory! > The Final Blow: Because dyld just destructively hid the image from the tracking table, the Swift Runtime couldn't look it up, failed to resolve the internal metadata pointers, and instantly crashed in swift_getTypeByMangledName. > By simply lying and writing minos 15.0 into the header, you caused policy.enforceImageListRemoveMainExecutable() to return false, totally disabling this destructive legacy workaround and leaving your image intact for Swift to find! 🔬🏆🏁 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
pull Bot
pushed a commit
that referenced
this pull request
Jun 1, 2026
flutter#187370) …gine (flutter#187268)" Reason for revert: removal of some snapshot binaries break mac code signing Looks like the removal of the MCP server snapshot (and others) caused the codesigning failure. Log from the Dart SDK roll that was in the reverted patch: https://dart.googlesource.com/sdk.git/+log/6833224264116d1becc20dd037d6c25c92194612..3cdc25e8ffe98c61b36af485573639dc833b75cb Failure logs for arm64 and x64 bots both show the same errors: * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20verify_binaries_pre_codesigned/5308 * https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_x64%20verify_binaries_pre_codesigned/5305/overview Errors: ``` Expected binaries not found in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/analysis_server.dart.snapshot /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/dart_mcp_server_aot.dart.snapshot /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/dartdevc.dart.snapshot /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/kernel-service.dart.snapshot If this commit is removing binaries from the cache, this test should be fixed by removing the relevant entry from either the "binariesWithEntitlements" or "binariesWithoutEntitlements" getters in dev/tools/lib/codesign.dart. ╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════ ║ UNEXPECTED ERROR! ║ Exception: Did not find all expected binaries! ║ #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:231:5) ║ <asynchronous suspension> ║ #1 verifyPreCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:40:3) ║ <asynchronous suspension> ║ #2 _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:727:7) ║ <asynchronous suspension> ║ #3 main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:123:5) ║ <asynchronous suspension> ║ ║ The test.dart script should be corrected to catch this error and call foundError(). ║ Some tests are likely to have been skipped. ╚═══════════════════════════════════════════════════════════════════════════════ Step failed (retcode: 255) ``` This reverts commit 6d7a865. <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
pull Bot
pushed a commit
that referenced
this pull request
Jun 2, 2026
Fixes flutter#184725 This PR makes the tool exit when building with XCode and we didn't parse any build setting. I understand that there are no cases where this map can be empty, as it includes the app bundle ID, which is required when building. If we don't exit, it can show unrelated error messages to the users which could be confusing and hard to debug. For instance, from the linked issue, one could end up getting: `No valid code signing certificates were found` simply because the development team build setting was not available, despite having valid certificates installed. Sample output: ``` [ +63 ms] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ ] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ +765 ms] Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:53.692 xcodebuild[9020:45597] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0053.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } [ ] Unexpected failure to get Xcode build settings: ProcessException: Process exited abnormally with exit code 64: Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:53.692 xcodebuild[9020:45597] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0053.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } Command: /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios. [ +2 ms] Archiving example.com.myapp... [ +25 ms] Migrating AppFrameworkInfo.plist contents [ ] Upgrading AppFrameworkInfo.plist [ ] Upgrading Podfile [ +9 ms] The Swift Package Manager feature is off. Skipping the migration that adds Swift Package Manager integration... [ +6 ms] executing: xattr -r -d com.apple.FinderInfo /Users/admin/builds/AEFj1IwjB/0/repo [+1948 ms] Failed to remove xattr com.apple.FinderInfo from /Users/admin/builds/AEFj1IwjB/0/repo [ +1 ms] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ ] executing: [/Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj/] /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios [ +920 ms] Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:56.608 xcodebuild[9023:45646] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0056.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } [ ] Unexpected failure to get Xcode build settings: ProcessException: Process exited abnormally with exit code 64: Command line invocation: /Applications/Xcode-26.3.0.app/Contents/Developer/usr/bin/xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios Build settings from command line: BUILD_DIR = /Users/admin/builds/AEFj1IwjB/0/repo/build/ios 2026-04-06 17:36:56.608 xcodebuild[9023:45646] Writing error result bundle to /var/folders/4p/084k9rr96ld_w60n8rdr0wtm0000gn/T/ResultBundle_2026-06-04_17-36-0056.xcresult xcodebuild: error: Could not configure request to show build settings: Unable to find a destination matching the provided destination specifier: { generic:1, platform:iOS } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 26.2 is not installed. Please download and install the platform from Xcode > Settings > Components. } Command: /usr/bin/arch -arm64e xcrun xcodebuild -project /Users/admin/builds/AEFj1IwjB/0/repo/ios/Runner.xcodeproj -scheme Runner -configuration Release -destination generic/platform=iOS -showBuildSettings BUILD_DIR=/Users/admin/builds/AEFj1IwjB/0/repo/build/ios. [ +66 ms] executing: which security [ +4 ms] executing: which openssl [ +22 ms] executing: security find-identity -p codesigning -v [ +57 ms] 1) <ID> "Apple Distribution: ACME. (<ID>)" 1 valid identities found [ +1 ms] ════════════════════════════════════════════════════════════════════════════════ No valid code signing certificates were found You can connect to your Apple Developer account by signing in with your Apple ID in Xcode and create an iOS Development Certificate as well as a Provisioning Profile for your project by: 1- Open the Flutter project's Xcode target with open ios/Runner.xcworkspace 2- Select the 'Runner' project in the navigator then the 'Runner' target in the project settings 3- Make sure a 'Development Team' is selected under Signing & Capabilities > Team. You may need to: - Log in with your Apple ID in Xcode first - Ensure you have a valid unique Bundle ID - Register your device with your Apple Developer Account - Let Xcode automatically provision a profile for your app 4- Build or run your project again 5- Trust your newly created Development Certificate on your iOS device via Settings > General > Device Management > [your new certificate] > Trust For more information, please visit: https://developer.apple.com/library/content/documentation/IDEs/Conceptual/ AppDistributionGuide/MaintainingCertificates/MaintainingCertificates.html Or run on an iOS simulator without code signing ════════════════════════════════════════════════════════════════════════════════ [ +1 ms] "flutter ipa" took 7,479ms. [ +2 ms] executing: sw_vers -productName [ +8 ms] Exit code 0 from: sw_vers -productName [ ] macOS [ ] executing: sw_vers -productVersion [ +6 ms] Exit code 0 from: sw_vers -productVersion [ ] 26.0 [ ] executing: sw_vers -buildVersion [ +6 ms] Exit code 0 from: sw_vers -buildVersion [ ] 25A354 [ ] executing: uname -m [ +10 ms] Exit code 0 from: uname -m [ ] arm64 [ +20 ms] No development certificates available to code sign app for device deployment [ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:34:3) #1 XcodeCodeSigningSettings._getCodeSigningBuildSettings (package:flutter_tools/src/ios/code_signing.dart:340:9) <asynchronous suspension> #2 buildXcodeProject (package:flutter_tools/src/ios/mac.dart:322:26) <asynchronous suspension> #3 _BuildIOSSubCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:986:37) <asynchronous suspension> #4 BuildIOSArchiveCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:477:50) <asynchronous suspension> #5 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1590:27) <asynchronous suspension> #6 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> #7 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> #8 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:496:9) <asynchronous suspension> #9 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> #10 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:431:5) <asynchronous suspension> #11 FlutterCommandRunner.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:307:33) <asynchronous suspension> #12 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:104:11) <asynchronous suspension> #13 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:19) <asynchronous suspension> #14 main (package:flutter_tools/executable.dart:103:3) <asynchronous suspension> [ ] Running 2 shutdown hooks [ ] Shutdown hooks complete [ +56 ms] exiting with code 1 ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Elijah Okoroh <[email protected]>
pull Bot
pushed a commit
that referenced
this pull request
Aug 12, 2026
…on documentation (flutter#190842) There are 2 files in this pr. One is a document the ai used to keep track of work. More importantly it acts kind of like issues so it references the items in future prs. The second is user facing website documentation. I do not know if we will use it verbatim but for the set of prs lets treat that md doc as human understandable documentation that we must understand before landing the next pr. Reviewers: When the pr is out of draft and your comments are fully addressed please prioritize this pr over other work. The review bar is higher, the number of reviews has more people and the work for the next pr is already done. - @reidbaker --- Standard review context for this pr stack This is PR is part of an 11 pr stack to migrate the "newdsl" `gradle-api` specifically in agp 9.1.0. The complete stack has pass pre submits, post submits and customer tests. https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=experimental/agp-gradle-api All of the code was LLM authored. A mix of manual prompting, automatic prompting, several models and adversarial review. The combined sessions are enough that I cannot include relevant prompts like I have been doing on other prs. If you want to review the pr stack you can find it here. These prs will be abandoned/closed as prs land into flutter/flutter. 1. reidbaker-agent#1 (branch: agp-api-doc) 2. reidbaker-agent#2 (branch: agp-internal-utils) 3. reidbaker-agent#3 (branch: agp-buildmode-deps) 4. reidbaker-agent#4 (branch: agp-plugin-buildtypes) 5. reidbaker-agent#5 (branch: agp-ndk-fallback) 6. reidbaker-agent#6 (branch: agp-assets-onvariants) 7. reidbaker-agent#7 (branch: agp-apk-copy-versioncode) 8. reidbaker-agent#8 (branch: agp-add-to-app) 9. reidbaker-agent#9 (branch: agp-aar-script) 10. reidbaker-agent#10 (branch: agp-newdsl-flip) 11. reidbaker-agent#11 (branch: agp-gradle-api) Follow up work is tracked in flutter#190964 This work is urgent in the sense that we are worried that android will publish agp 10 with no opt out but not so urgent that we are willing to break flutter users because we didn't review or understand the code because we were in a rush. Breaking changes are expected as part of this work. There are patterns the android team explicitly does not want apps to use and apis that have no equivalent. As part of the effort to ensure this work does not slip into ai slop, prs from this stack will be reviewed by me (@reidbaker) before asking for review. Then we will have 2 android expert reviewers also review the every pr. --- Agent authored pr description This is PR 1 of 11 in the AGP 9.1.0 / public `gradle-api` migration stack. It adds the contributor-facing and website draft documentation for the Flutter Gradle Plugin's migration to the Android Gradle Plugin public Variant API, which unblocks building Flutter Android apps with AGP's `newDsl=true` enabled. Part of flutter#180137 and flutter#166550. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: reidbaker-agent <[email protected]>
pull Bot
pushed a commit
that referenced
this pull request
Sep 15, 2026
…#192650) Fixes flutter#192227 **Problem** `AppDomain.launch` sends the `app.start` event, which carries the app ID, before `ResidentRunner.run()` has compiled and called `generator.accept()`. A client that acts on that ID immediately can land an `app.restart` in the gap, producing a `recompile` against a compiler with no accepted baseline. `frontend_server` then crashes on `lastKnownGoodResult!`, and the app fails to start. **Fix** `AppDomain.restart` now waits on a new `AppInstance.started` before entering the debounce queue, so the compiler is never asked to recompile before it has a baseline. **Demo** No URLs: the bug is in the `flutter run --machine` daemon protocol, not in rendered output, so a deployed build has no daemon to race. Verified locally with a harness that sends `app.restart` during the initial compile, which is the window this closes. Before, it reproduces the exact trace from the issue and the app dies: Null check operator used on a null value #0 FrontendCompiler.writeJavaScriptBundle (frontend_server.dart:1100) #1 FrontendCompiler.recompileDelta (frontend_server.dart:1312) #2 listenAndCompile.<anonymous closure> (frontend_server.dart:1806) App failed to start After, the restart is held until `app.started` and returns `code: 0`.
pull Bot
pushed a commit
that referenced
this pull request
Sep 26, 2026
Fixes flutter#110488. ### Background: The `testWidgets` Lifecycle Understanding this change requires distinguishing between two layers of `Future`s and two distinct verification steps in `testWidgets`: #### 1. Two Layers of `Future`s * **`testBody()` Future**: The closure containing the user's test logic. * **`runTest()` Future**: The overall async harness returned by `binding.runTest()`. It manages the test zone, unmounts the widget tree, and resolves only after `testBody()` and test-specific verifications finish. #### 2. Two Distinct Verification Phases * **Test-specific verifications (`invariantTester`)**: Passed as a callback to `runTest` and executed synchronously inside `_runTestBody` immediately after the `testBody()` Future completes and the widget tree is unmounted. In `testWidgets`, this runs `tester._endOfTestVerifications` to verify that tickers and semantics handles were disposed. * **Framework-level invariant checks**: Verifies global framework state, including ensuring foundation/rendering/widgets debug flags were reset and no non-periodic timers or animations remain. #### 3. The Teardown Lifecycle & Root Cause of flutter#110488 When `testWidgets` runs: 1. `testWidgets` registers `test_package.addTearDown(binding.postTest)` with `package:test`. 2. `testWidgets` calls and returns `binding.runTest(...)`. 3. Inside `testBody()`, users may register cleanups using `addTearDown` (for example, `addTearDown(() => debugDefaultTargetPlatformOverride = null)`). 4. `package:test` executes teardowns in **LIFO (reverse registration) order** only *after* the Future returned by `runTest` completes. Previously, framework-level invariant checks ran at the end of `_runTestBody` *before* the `runTest` Future completed. As a result, they ran before `package:test` executed any user-registered `addTearDown` callbacks, causing tests that clean up debug flags via `addTearDown` to fail invariant verification (flutter#110488). The following diagram shows the code flow after this PR: ``` testWidgets(description, (tester) async { ... }) │ ├── 1. Registration Phase │ └── test_package.addTearDown(binding.postTest) [Teardown Stack: #1] │ ├── 2. Test Execution Phase: binding.runTest(...) │ │ │ │ [ Future 1: testBody() ] │ ├──► Run testBody(tester) │ │ └── User calls addTearDown(...) [Teardown Stack: #2] │ │ │ │ [ Post-testBody cleanup (inside runTest) ] │ ├──► Unmount widget tree (runApp) │ ├──► Verification 1: invariantTester() (tickers, semantics) │ └──► Set _shouldVerifyInvariants = true │ │ [ Future 2: runTest() completes ] │ └── 3. Teardown Phase: package:test executes in LIFO order │ ├──► [Step 1] User Teardowns (Stack #2) │ └── e.g., debugDefaultTargetPlatformOverride = null │ └──► [Step 2] binding.postTest() (Stack #1) ├── Verification 2: Framework Invariants (debug vars, timers) ├── Reset Binding State (_currentFakeAsync, etc.) └── reportTestException(...) (if Verification 2 failed) ``` ### Changes & Design Rationale #### 1. Defer Framework Invariant Checks to `postTest` Framework invariant checks (`_verifyInvariants()`, `_verifyAutoUpdateGoldensUnset`, etc.) are moved from `_runTestBody` into `TestWidgetsFlutterBinding.postTest`. Because `testWidgets` registers `binding.postTest` before running the test body, `package:test`'s LIFO teardown ordering guarantees that all user-registered `addTearDown` callbacks execute before `binding.postTest`. #### 2. Clarifying the `postTest` Error Contract Previously, `postTest` only performed state cleanup and did not check invariants. Moving invariant checks into `postTest` introduced the question of how invariant failures should be propagated: allowing `postTest` to throw, or absorbing errors and reporting them via `reportTestException`. We explicitly define the contract of `postTest` to **not throw exceptions**, reporting any invariant failures via `reportTestException`: * **Rationale & Trade-offs**: * *Alternative considered (throwing)*: If `super.postTest()` threw on an invariant failure, `package:test` would still capture the failure. However, subclasses (`AutomatedTestWidgetsFlutterBinding`, `LiveTestWidgetsFlutterBinding`, or custom bindings) override `postTest` to reset their own state (e.g. nulling `_currentFakeAsync` / `_clock`, or setting `_inTest = false`). Allowing `super.postTest()` to throw would require every subclass to defensively wrap `super.postTest()` in `try ... finally`. If any subclass omitted this, an invariant failure would leave the binding in a dirty state and trigger cascading `!inTest` failures in subsequent tests. * *Chosen approach (non-throwing)*: Absorbing errors in `postTest` and forwarding them to `reportTestException` guarantees that all cleanup in base and subclass implementations executes sequentially without defensive `try ... finally` boilerplate, while still cleanly failing the test. **Why this does not break existing behavior:** In the previous implementation, when invariant assertions failed inside `_runTestBody`, they were caught by `_testZone.handleUncaughtError` and forwarded to `reportTestException` (which delegates to `package:test.registerException`). They never escaped `runTest` as unhandled thrown exceptions. Catching invariant failures in `postTest` and routing them to `reportTestException` preserves this exact error reporting pipeline, diagnostic output, and failure semantics without disrupting teardown execution. #### 3. Preserving Existing Behavior on Failed Tests (`_shouldVerifyInvariants`) Historically, `_runTestBody` only verified invariants if the test body did not fail: ```dart if (_pendingExceptionDetails == null) { // We only try to clean up and verify invariants if we didn't already // fail. If we got an exception already, then we instead leave everything // alone so that we don't cause more spurious errors. ... _verifyInvariants(); } ``` When invariant checks are moved to `postTest`, `_pendingExceptionDetails` is no longer available because it has already been reported and cleared by `testCompletionHandler` when `runTest` completed. To preserve this exact existing behavior across the lifecycle boundary, `_shouldVerifyInvariants` is introduced. It is set to `true` at the end of `_runTestBody` only when `_pendingExceptionDetails == null`. If a test fails in its body, `_shouldVerifyInvariants` remains `false`, and `postTest` skips invariant checks—ensuring no behavior change and preventing spurious errors (e.g. active animations on an unmounted tree) from masking the real failure. #### 4. Documentation Updates Updated the doc comments on: * `TestWidgetsFlutterBinding.postTest`: Documents the non-throwing contract, the `@mustCallSuper` requirement, and error reporting via `reportTestException`. * `TestWidgetsFlutterBinding.runTest`: Clarifies the distinction between `invariantTester` (which runs before `runTest` completes) and framework invariant checks (which run in `postTest` after `runTest` and user teardowns complete). ### Tests - Added unit tests in `packages/flutter_test/test/bindings_invariants_test.dart` verifying that foundation variables (`debugDefaultTargetPlatformOverride`, `debugDoublePrecision`, `debugBrightnessOverride`), `autoUpdateGoldenFiles`, `ErrorWidget.builder`, and `shouldPropagateDevicePointerEvents` can all be reset using `addTearDown`. - Added test cases verifying invariant failures in `postTest` and ensuring invariant checks are skipped when the test body throws. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
pull Bot
pushed a commit
that referenced
this pull request
Sep 26, 2026
) Reverts: [Allow resetting test invariants in `addTearDown`](flutter#192082) Initiated by: @b-luk Reason for reverting: Breaks tree with tool_integration_tests failures. Example: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_2/1329/overview Original PR Author: @dkwingsmt Reviewed By: @justinmc The original PR description is provided below: Fixes flutter#110488. ### Background: The `testWidgets` Lifecycle Understanding this change requires distinguishing between two layers of `Future`s and two distinct verification steps in `testWidgets`: #### 1. Two Layers of `Future`s * **`testBody()` Future**: The closure containing the user's test logic. * **`runTest()` Future**: The overall async harness returned by `binding.runTest()`. It manages the test zone, unmounts the widget tree, and resolves only after `testBody()` and test-specific verifications finish. #### 2. Two Distinct Verification Phases * **Test-specific verifications (`invariantTester`)**: Passed as a callback to `runTest` and executed synchronously inside `_runTestBody` immediately after the `testBody()` Future completes and the widget tree is unmounted. In `testWidgets`, this runs `tester._endOfTestVerifications` to verify that tickers and semantics handles were disposed. * **Framework-level invariant checks**: Verifies global framework state, including ensuring foundation/rendering/widgets debug flags were reset and no non-periodic timers or animations remain. #### 3. The Teardown Lifecycle & Root Cause of flutter#110488 When `testWidgets` runs: 1. `testWidgets` registers `test_package.addTearDown(binding.postTest)` with `package:test`. 2. `testWidgets` calls and returns `binding.runTest(...)`. 3. Inside `testBody()`, users may register cleanups using `addTearDown` (for example, `addTearDown(() => debugDefaultTargetPlatformOverride = null)`). 4. `package:test` executes teardowns in **LIFO (reverse registration) order** only *after* the Future returned by `runTest` completes. Previously, framework-level invariant checks ran at the end of `_runTestBody` *before* the `runTest` Future completed. As a result, they ran before `package:test` executed any user-registered `addTearDown` callbacks, causing tests that clean up debug flags via `addTearDown` to fail invariant verification (flutter#110488). The following diagram shows the code flow after this PR: ``` testWidgets(description, (tester) async { ... }) │ ├── 1. Registration Phase │ └── test_package.addTearDown(binding.postTest) [Teardown Stack: #1] │ ├── 2. Test Execution Phase: binding.runTest(...) │ │ │ │ [ Future 1: testBody() ] │ ├──► Run testBody(tester) │ │ └── User calls addTearDown(...) [Teardown Stack: #2] │ │ │ │ [ Post-testBody cleanup (inside runTest) ] │ ├──► Unmount widget tree (runApp) │ ├──► Verification 1: invariantTester() (tickers, semantics) │ └──► Set _shouldVerifyInvariants = true │ │ [ Future 2: runTest() completes ] │ └── 3. Teardown Phase: package:test executes in LIFO order │ ├──► [Step 1] User Teardowns (Stack #2) │ └── e.g., debugDefaultTargetPlatformOverride = null │ └──► [Step 2] binding.postTest() (Stack #1) ├── Verification 2: Framework Invariants (debug vars, timers) ├── Reset Binding State (_currentFakeAsync, etc.) └── reportTestException(...) (if Verification 2 failed) ``` ### Changes & Design Rationale #### 1. Defer Framework Invariant Checks to `postTest` Framework invariant checks (`_verifyInvariants()`, `_verifyAutoUpdateGoldensUnset`, etc.) are moved from `_runTestBody` into `TestWidgetsFlutterBinding.postTest`. Because `testWidgets` registers `binding.postTest` before running the test body, `package:test`'s LIFO teardown ordering guarantees that all user-registered `addTearDown` callbacks execute before `binding.postTest`. #### 2. Clarifying the `postTest` Error Contract Previously, `postTest` only performed state cleanup and did not check invariants. Moving invariant checks into `postTest` introduced the question of how invariant failures should be propagated: allowing `postTest` to throw, or absorbing errors and reporting them via `reportTestException`. We explicitly define the contract of `postTest` to **not throw exceptions**, reporting any invariant failures via `reportTestException`: * **Rationale & Trade-offs**: * *Alternative considered (throwing)*: If `super.postTest()` threw on an invariant failure, `package:test` would still capture the failure. However, subclasses (`AutomatedTestWidgetsFlutterBinding`, `LiveTestWidgetsFlutterBinding`, or custom bindings) override `postTest` to reset their own state (e.g. nulling `_currentFakeAsync` / `_clock`, or setting `_inTest = false`). Allowing `super.postTest()` to throw would require every subclass to defensively wrap `super.postTest()` in `try ... finally`. If any subclass omitted this, an invariant failure would leave the binding in a dirty state and trigger cascading `!inTest` failures in subsequent tests. * *Chosen approach (non-throwing)*: Absorbing errors in `postTest` and forwarding them to `reportTestException` guarantees that all cleanup in base and subclass implementations executes sequentially without defensive `try ... finally` boilerplate, while still cleanly failing the test. **Why this does not break existing behavior:** In the previous implementation, when invariant assertions failed inside `_runTestBody`, they were caught by `_testZone.handleUncaughtError` and forwarded to `reportTestException` (which delegates to `package:test.registerException`). They never escaped `runTest` as unhandled thrown exceptions. Catching invariant failures in `postTest` and routing them to `reportTestException` preserves this exact error reporting pipeline, diagnostic output, and failure semantics without disrupting teardown execution. #### 3. Preserving Existing Behavior on Failed Tests (`_shouldVerifyInvariants`) Historically, `_runTestBody` only verified invariants if the test body did not fail: ```dart if (_pendingExceptionDetails == null) { // We only try to clean up and verify invariants if we didn't already // fail. If we got an exception already, then we instead leave everything // alone so that we don't cause more spurious errors. ... _verifyInvariants(); } ``` When invariant checks are moved to `postTest`, `_pendingExceptionDetails` is no longer available because it has already been reported and cleared by `testCompletionHandler` when `runTest` completed. To preserve this exact existing behavior across the lifecycle boundary, `_shouldVerifyInvariants` is introduced. It is set to `true` at the end of `_runTestBody` only when `_pendingExceptionDetails == null`. If a test fails in its body, `_shouldVerifyInvariants` remains `false`, and `postTest` skips invariant checks—ensuring no behavior change and preventing spurious errors (e.g. active animations on an unmounted tree) from masking the real failure. #### 4. Documentation Updates Updated the doc comments on: * `TestWidgetsFlutterBinding.postTest`: Documents the non-throwing contract, the `@mustCallSuper` requirement, and error reporting via `reportTestException`. * `TestWidgetsFlutterBinding.runTest`: Clarifies the distinction between `invariantTester` (which runs before `runTest` completes) and framework invariant checks (which run in `postTest` after `runTest` and user teardowns complete). ### Tests - Added unit tests in `packages/flutter_test/test/bindings_invariants_test.dart` verifying that foundation variables (`debugDefaultTargetPlatformOverride`, `debugDoublePrecision`, `debugBrightnessOverride`), `autoUpdateGoldenFiles`, `ErrorWidget.builder`, and `shouldPropagateDevicePointerEvents` can all be reset using `addTearDown`. - Added test cases verifying invariant failures in `postTest` and ensuring invariant checks are skipped when the test body throws. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )