Modularize coloured ToT Medallions hook #5877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
reviewed
Oct 24, 2025
Contributor
Author
|
Failing check? |
Contributor
|
Transient macports issue. It's been happening more and more recently for a reason we don't know. |
Malkierian
reviewed
Oct 26, 2025
Malkierian
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SohMenuEnhancements.cppneeds this update function, so I've split it in two for the option widget and used the patch branch specifically for theCOND_HOOK.I also made a patch data structure class to clean up all the duplicate code.
Based on
develop-copperbecause it also fixes a bug in the hook by adding an overlooked unpatch to the reset function.Build Artifacts