Adds saving and loading for location exclusion, and hooks the check t… #5594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racker up to return false from IsVisibleInCheckTracker if a location was excluded.
Pepper0ni
reviewed
Jun 17, 2025
| }); | ||
| } | ||
| if (randoContext->GetItemLocation(i)->IsExcluded()) { | ||
| SaveManager::Instance->SaveData("excluded", true); |
Contributor
There was a problem hiding this comment.
This is fine for a quick fix for Blair Delta, but it strikes me as odd that excludes are stored as settings everywhere else but part of the ItemLocation while saving. I don't exactly mind storing excludes this way but could it become weird if we ever change excludes to just remove the location from the pool and always give a nothing check?
Contributor
Author
There was a problem hiding this comment.
Only if we also change the way locations are stored in the save. At the moment, every location, regardless of shuffle, is saved in the save file.
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Jun 24, 2025
…racker up to return false from IsVisibleInCheckTracker if a location was excluded. (HarbourMasters#5594)
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…racker up to return false from IsVisibleInCheckTracker if a location was excluded. (HarbourMasters#5594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds saving and loading for location exclusion status in the save file, and hooks the check tracker into it to return false from
IsVisibleInCheckTracker()if a location was excluded.Build Artifacts