Fix Search Crash from Scrolling #5571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The audio editor could encounter this as well, especially in the voices tab. |
serprex
approved these changes
Jun 11, 2025
Pepper0ni
approved these changes
Jun 11, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Jun 16, 2025
* Fix search crashing when section child scrolled too far. * clang
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* Fix search crashing when section child scrolled too far. * clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search would crash when the section window was scrolled too far for the search results to actually display, because the stuff drawing it wasn't gated behind an
if(ImGui::BeginChild()), but rather statically called BeginChild(). This was difficult to encounter outside of the flags tab in the save editor because the rando inf section was so long.Build Artifacts