Hookify TreesDropSticks #5566
Merged
Hookify TreesDropSticks #5566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
I seem to always get at least 1 stick now, and sometimes get 4. off by 1 error? |
Contributor
Author
|
I thought it was supposed to be 1-4, not 0-3. So off-by-one error was in my head. Will adjust |
serprex
commented
Jun 11, 2025
Pepper0ni
approved these changes
Jun 11, 2025
Contributor
Pepper0ni
left a comment
Pepper0ni
left a comment
There was a problem hiding this comment.
LGTM, there may be a time where this gets reworked to allow dropping vanilla pickups as well for logic reasons, but as a straight port this seems to work fine
Malkierian
reviewed
Jun 11, 2025
Malkierian
approved these changes
Jun 11, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* Hookify TreesDropSticks * fix off by one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts