-
Notifications
You must be signed in to change notification settings - Fork 632
Save and Randomizer Version Control #5557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save and Randomizer Version Control #5557
Conversation
Add spoiler drop fail sound (sys_error). Improve path sanitizer operation. Add check for a spoiler having a version and it equaling running version. Deletes spoiler CVar if spoiler becomes unusuable while running, and prevents loading dropped spoilers that don't match.
Does this mean that a randomizer save created in one version of SoH cannot be used in another version? And if so, does that include between separate dev commits (after the future point when this is pushed from Blair to dev), or only between full numbered versions of SoH? |
yes (this was never really supported anyways, & not really in demand either) only between numbered versions of SoH |
Remove duplicate Sanitize from Context and make it use SohUtils. Fix typo.
* Add version control for Rachael saves and old rando saves. * Change spoiler drop success sound to puzzle success chime. Add spoiler drop fail sound (sys_error). Improve path sanitizer operation. Add check for a spoiler having a version and it equaling running version. Deletes spoiler CVar if spoiler becomes unusuable while running, and prevents loading dropped spoilers that don't match. * clang * Remove backslash escaping from Sanitize. Remove duplicate Sanitize from Context and make it use SohUtils. Fix typo.
This accomplishes multiple things:
sohStatsinclusion and thus do not have SoH version saved, are assumed to be vanilla saves from Rachael, where randomizer data was always saved even if it wasn't a rando file, and have the rando sections removed.In all cases, the user is notified via SohModals of the occurrence and reason.
This targets Blair because it's fixing several instances of possible crashing.
Build Artifacts