Fix crash when no valid enemies are selected #5519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
May 19, 2025
Pepe20129
approved these changes
May 19, 2025
Malkierian
approved these changes
May 22, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 23, 2025
* fix crash when no valid enemies are selected * Clanged
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 23, 2025
* fix crash when no valid enemies are selected * Clanged
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 23, 2025
* fix crash when no valid enemies are selected * Clanged
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 26, 2025
* fix crash when no valid enemies are selected * Clanged
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Jun 3, 2025
* fix crash when no valid enemies are selected * Clanged
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* fix crash when no valid enemies are selected * Clanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some enemies cannot appear in clear rooms or timed rooms. If only these enemies were selected, it would cause a lock when the player tried to enter those rooms as there would be an infinite loop of trying and failing to select an enemy. This PR changes the way enemies are selected to remove any looping and also adds a fallback where if nothing valid is available, it allows invalid enemies to spawn.
Build Artifacts