-
Notifications
You must be signed in to change notification settings - Fork 632
Fix warnings #5516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #5516
Conversation
cb8b83c to
22eac0c
Compare
|
First commit is not about warnings, but instead addressing TODO about whether uint8_t is necessary I've updated hint code to use size_t in places where the indexes are just being passed around, & not actually stored anywhere. At best |
briaguya0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks great! couple little comments, one has a small suggestion
|
this seemed to fix something for @Pepper0ni |
|
You've marked a lot of classes |
Pepper0ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hint stuff seems fine, but I can't give an opinion on Rozelette's comment.
warning: second argument to 'va_arg' is of promotable type 's16' (aka 'short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
* use size_t instead of uint8_t for hint ids * va_arg int instead of s16 warning: second argument to 'va_arg' is of promotable type 's16' (aka 'short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs] * more issues like HarbourMasters#5443
null
Build Artifacts