fix seed gen underflow #5499
Merged
fix seed gen underflow #5499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
These iterate backwards because the logic looks to remove items from later spheres first to preserve the earliest way to get a given item. If they didn't iterate backwards, the playthrough would be a mess of all the latest ways to get items and things being in spheres before what unlocked them. |
Contributor
Author
|
that makes sense for the spheres themselves, less clear why that's happening for the locations within the spheres |
Contributor
|
I can't think of a reason for the locations as everything within the same sphere has the same accessibility. That could be safely uninverted. |
Malkierian
approved these changes
May 17, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5486 changed a couple for loops in
PareDownPlaythroughto use an unsignedsize_tinstead of a signedint. these loops iterate backwards (usingi--andj--), and rely on checkingi >= 0/j >= 0. switching to signed caused these to underflow.those loops have been around unchanged forever (followed the blame back to #416) - and i'm not sure why exactly they rely on iterating backwards but i didn't want to touch it when making this fix.
Build Artifacts