explicitly set c standard to 17 #5492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
May 16, 2025
Merged
Merged
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was looking into #5467 and i did a bit of digging.
it seems the gcc15 issues are stemming from 15 changing the default C version from
gnu17tognu23.we didn't have the c standard explicitly set before, leading to compiler defaults being used.
our CI builds use gcc12 which defaults to c17. i think for consistency in blair it makes sense to fix the gcc15 issue by explicitly setting the c standard to c17.
i ran some test builds using a modified
test-builds-on-distrosworkflow (i just removed everything but arch and gcc from it) and was able to get the project to successfully build with this change.i do think updating the code to work with the c23 standard is a reasonable thing to do, and i think #5467 does a great job of it, but i would prefer we do that in
developinstead.Build Artifacts