Add/Restore the option to automatically boot into Debug Warp Screen #5485
Conversation
|
I forgot to run clang-format... I request reopening the PR. |
|
You currently get forced into the debug warp screen when you boot file 1 in debug mode, does this override that functionality (which i assume is vanilla?) |
"debug warp screen when you boot file 1 in debug mode" is indeed a vanilla Debug ROM behavior. This Pull Request does not change that behavior. |
Pepper0ni
left a comment
Pepper0ni
left a comment
There was a problem hiding this comment.
It feels a little weird to have this setting separate from the boot screen controls, but it makes some sense as a debug setting, so it should be fine.
| } | ||
|
|
||
| // Boot to Debug Warp Screen | ||
| if ((CVarGetInteger(CVAR_DEVELOPER_TOOLS("DebugEnabled"), 0) != 0) && |
There was a problem hiding this comment.
This should be done in a hook
nclok1405
force-pushed
the
boot2debugwarp
branch
from
b354b16 to
a0604db
Compare
… Warp from being triggered when Boot to Debug Warp option is enabled but Debug Mode option is disabled.
|
I've added a new hook and moved most of Boot to Debug Warp Screen code to the newly added hook. As for toggle location, I think it should remain separated from Boot Sequence dropdown list (then known as "Fast File Select") because it was "overcomplicated" (#4882). The ability to boot into the Debug Warp Screen was removed during Boot Sequence option redesign, but it is very useful for quick testing and development usage, so this ability should return, just hidden behind Dev Tools tab. |
…arbourMasters#5485) * Added/Restored the option to automatically boot into Debug Warp Screen * clang-formated * Added a new hook and moved Boot To Debug Warp Screen to it * clang * Added DebugEnabled to initFunc's CVar list. This should prevent Debug Warp from being triggered when Boot to Debug Warp option is enabled but Debug Mode option is disabled. * No longer hijacks CustomLogoTitle * Disable "Boot Sequence" dropdown when Boot to Debug Warp Screen is enabled
3 participants
This Pull Request adds (back) the ability to directly launch into the Debug Warp Screen when launching or resetting the game.
This is intended only for developer/quick testing use, so the toggle is located at Dev Tools section and require the Debug Mode to have any effect.
Build Artifacts