Update auto-format to better handle puctuation and add #5422 's translations #5426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Apr 20, 2025
ReddestDream
added a commit
to ReddestDream/Shipwright
that referenced
this pull request
Apr 22, 2025
…ourMasters#5426)" This reverts commit fbbfc07.
xxAtrain223
pushed a commit
to xxAtrain223/Shipwright
that referenced
this pull request
May 4, 2025
…rs#5426) --- Co-authored-by: PurpleHato <[email protected]> Co-authored-by: amafresh <[email protected]>
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…rs#5426) --- Co-authored-by: PurpleHato <[email protected]> Co-authored-by: amafresh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A merge or #5424 and #5422, thanks for Purple Hato for the french translations and Ama-Fresh for the german translations.
This PR changes auto-format to consider spaces and punctuation equally for deciding line-breaks, and adds exclamation points, commas, hyphens and question marks to the list of punctuation that it can break after. Additionally there is now a handler for if there is a word being too long for 1 line, preventing a crash.
The translations were merged into this PR to help test the new auto-format, as the crash was discovered with a new german translation.
Build Artifacts