timesavers: shipinit #5416
Merged
timesavers: shipinit #5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
shipinit-timesavers
branch
from
9b7b829 to
21724f4
Compare
leggettc18
previously requested changes
Apr 17, 2025
Contributor
leggettc18
left a comment
leggettc18
left a comment
There was a problem hiding this comment.
Good work! I've got a couple of things I'd like you to change but in general I like what I'm seeing here!
soh/soh/Enhancements/TimeSavers/SkipCutscene/Story/SkipBlueWarp.cpp
Outdated
Show resolved
Hide resolved
serprex
force-pushed
the
shipinit-timesavers
branch
from
03df490 to
8c00b4e
Compare
Contributor
Author
|
This PR is a little hairy, but it moves in the right direction. |
serprex
force-pushed
the
shipinit-timesavers
branch
from
e1c8ab1 to
0f5c77e
Compare
Pepper0ni
approved these changes
Jun 12, 2025
Contributor
Pepper0ni
left a comment
Pepper0ni
left a comment
There was a problem hiding this comment.
Did some testing, and everything seems to work, except for pre-existing essues that are out of scope for a simply hook change
Malkierian
approved these changes
Jun 18, 2025
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
* timesavers: shipinit * feedback * intro skip not unconditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts