fix TODO_TRANSLATE language replacement in cases where the text is already formatted #5415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leggettc18
approved these changes
Apr 16, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Apr 19, 2025
…ready formatted (HarbourMasters#5415) * fix TODO_TRANSLATE language replacement in cases where the text is already formatted * oops
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
Apr 22, 2025
…ready formatted (HarbourMasters#5415) * fix TODO_TRANSLATE language replacement in cases where the text is already formatted * oops
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 4, 2025
…ready formatted (HarbourMasters#5415) * fix TODO_TRANSLATE language replacement in cases where the text is already formatted * oops
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 8, 2025
…ready formatted (HarbourMasters#5415) * fix TODO_TRANSLATE language replacement in cases where the text is already formatted * oops
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…ready formatted (HarbourMasters#5415) * fix TODO_TRANSLATE language replacement in cases where the text is already formatted * oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, this fixes randomiser text fallbacks when playing on german
Also fixed another enumeration comparison warning
Build Artifacts