Remove redundent entrance logic check when adding a region to the pool. #5413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
Apr 17, 2025
Malkierian
approved these changes
Apr 23, 2025
ReddestDream
pushed a commit
to ReddestDream/Shipwright
that referenced
this pull request
May 4, 2025
…l. (HarbourMasters#5413) * remove redundent entrance logic check when adding a region to the pool. * how did this trigger clang...
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…l. (HarbourMasters#5413) * remove redundent entrance logic check when adding a region to the pool. * how did this trigger clang...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entrance conditions were getting run twice when first adding a region to the region pool as the ToDAccess check and the Region Pool addition were both running effectively the same check. This merges them for a minor optimization (seems to be around 2% shorter seed generation on beginner seeds on debug)
Build Artifacts