-
Notifications
You must be signed in to change notification settings - Fork 632
rando: always spawn gerudo guard behind gate (also fix gaurd typos) #5399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rando: always spawn gerudo guard behind gate (also fix gaurd typos) #5399
Conversation
someone had seed where they had card so couldn't be caught to pass gate in reverse wasteland
Pepper0ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainers might want this hooked while it has attention, but the code works
ecf1c2b to
a671ca2
Compare
a671ca2 to
f6a74ca
Compare
|
Yeah if converting to Hook is at all possible we'd appreciate at least an attempt at it. EDIT: Oh sweet, looks like you already did it, great! I'm guessing it now runs on all rando seeds, since I'm not seeing any additional qualifiers to when it spawns. Before it spawned only in Overworld Entrance Shuffle, and the impetus for this change was preventing desert spawn softlocks right? |
|
Entrance shuffle and gerudo card shuffle, it was part opening up the logic, part lowering no logic impossible starts and part QoL, but the big impetus for this change is that without her, you can pass the gate backwards as adult but only if you do NOT have a g-card, as you can get caught through the gate to get sent to jail on the other side. Having the extra guard always exist just prevents there from being any cases where something becomes impossible because you found gerudo card, which is also the reasoning behind have guards offer to throw you in jail. |
|
Yeah I think I'm in favor of the other guard just always being there. Not sure why it was ever so strictly locked down to specific settings in hindsight. Once 9.0.2 is out I'll download this and see if I can hit any edge cases or something. |
|
This also helps in Shuffle Climb so logic is consistently "you can open gate from GF with card & climb, or you can open gate from HW with just card" |
|
Works for me! Like I said I'll want to playtest and make sure I can't hit any edge cases but it looks good from a code perspective. |
|
@leggettc18 when do you expect to have a chance to playtest? would it be better to have someone else look over this PR? |
|
I'm leaning toward merging this and having testing later, as it's already much more open than it was before, so if there are any edge cases, they will be much fewer and farther between as it is. However, are there generator logic considerations that need to be handled? |
|
I'll double check the logic in #5338 |
…arbourMasters#5399) * rando: always spawn guard behind gate (also fix gaurd typos) someone had seed where they had card so couldn't be caught to pass gate in reverse wasteland * move guard spawn logic to hook
someone had seed where they had card so couldn't be caught to pass gate in reverse wasteland
Build Artifacts