Skip to content

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Apr 13, 2025

someone had seed where they had card so couldn't be caught to pass gate in reverse wasteland

Build Artifacts

someone had seed where they had card so couldn't be caught to pass gate in reverse wasteland
@serprex serprex changed the title rando: always spawn guard behind gate (also fix gaurd typos) rando: always spawn gerudo guard behind gate (also fix gaurd typos) Apr 13, 2025
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainers might want this hooked while it has attention, but the code works

@serprex serprex force-pushed the always-spawn-gerudo-outside-haunted-wasteland branch from ecf1c2b to a671ca2 Compare April 13, 2025 21:35
@serprex serprex force-pushed the always-spawn-gerudo-outside-haunted-wasteland branch from a671ca2 to f6a74ca Compare April 13, 2025 22:26
@leggettc18
Copy link
Contributor

leggettc18 commented Apr 14, 2025

Yeah if converting to Hook is at all possible we'd appreciate at least an attempt at it.

EDIT: Oh sweet, looks like you already did it, great! I'm guessing it now runs on all rando seeds, since I'm not seeing any additional qualifiers to when it spawns. Before it spawned only in Overworld Entrance Shuffle, and the impetus for this change was preventing desert spawn softlocks right?

@Pepper0ni
Copy link
Contributor

Entrance shuffle and gerudo card shuffle, it was part opening up the logic, part lowering no logic impossible starts and part QoL, but the big impetus for this change is that without her, you can pass the gate backwards as adult but only if you do NOT have a g-card, as you can get caught through the gate to get sent to jail on the other side.

Having the extra guard always exist just prevents there from being any cases where something becomes impossible because you found gerudo card, which is also the reasoning behind have guards offer to throw you in jail.

@leggettc18
Copy link
Contributor

Yeah I think I'm in favor of the other guard just always being there. Not sure why it was ever so strictly locked down to specific settings in hindsight. Once 9.0.2 is out I'll download this and see if I can hit any edge cases or something.

@serprex
Copy link
Contributor Author

serprex commented Apr 14, 2025

This also helps in Shuffle Climb so logic is consistently "you can open gate from GF with card & climb, or you can open gate from HW with just card"

@leggettc18
Copy link
Contributor

Works for me! Like I said I'll want to playtest and make sure I can't hit any edge cases but it looks good from a code perspective.

@serprex
Copy link
Contributor Author

serprex commented May 28, 2025

@leggettc18 when do you expect to have a chance to playtest? would it be better to have someone else look over this PR?

@Malkierian
Copy link
Contributor

I'm leaning toward merging this and having testing later, as it's already much more open than it was before, so if there are any edge cases, they will be much fewer and farther between as it is. However, are there generator logic considerations that need to be handled?

@Pepper0ni
Copy link
Contributor

I'll double check the logic in #5338

@Malkierian Malkierian merged commit c0ea595 into HarbourMasters:develop Jun 19, 2025
6 checks passed
krazyjakee pushed a commit to krazyjakee/OOT that referenced this pull request Sep 6, 2025
…arbourMasters#5399)

* rando: always spawn guard behind gate (also fix gaurd typos)

someone had seed where they had card so couldn't be caught to pass gate in reverse wasteland

* move guard spawn logic to hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants