Fix Tracker Colors #5369
Merged
Fix Tracker Colors #5369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add temporary additional clearing to CVarColorPicker's reset functionality to resolve already migrated issues.
leggettc18
approved these changes
Apr 9, 2025
Contributor
leggettc18
left a comment
leggettc18
left a comment
There was a problem hiding this comment.
Side Note, people who have already updated their ship JSON won't have their CVars updated. Totally fine with leaving them in there for anyone who hasn't migrated yet though.
Contributor
Author
|
Technically won't be an issue anyway, as those people are already having to change their colors again anyway. But resetting will make them remember again. |
krazyjakee
pushed a commit
to krazyjakee/OOT
that referenced
this pull request
Sep 6, 2025
…asters#5369) Add temporary additional clearing to CVarColorPicker's reset functionality to resolve already migrated issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes migrators for tracker colors to match new menu formats.
Adds temporary additional clearing to CVarColorPicker's reset functionality to resolve already migrated issues.
There is a TODO associated with those for removal in the next major or minor revision, once this should be resolved.
Build Artifacts