-
Notifications
You must be signed in to change notification settings - Fork 632
Faster empty bottle, faster bean skulltula #5355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster empty bottle, faster bean skulltula #5355
Conversation
eccd7d3 to
66c144e
Compare
Pepper0ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth mention it only applies to bugs/fish/blue fire on the tooltip, but I wouldn't block over it
|
The changes work well, but I think this should be converted to the ShipInit pattern. What that basically means for you is that instead of the hooks always being registered and having an early return, ShipInit will register/unregister the hooks whenever the corresponding CVars change. I think there's a few examples in the codebase already, my Custom Message Hooks branch has several more examples. |
|
Best Example I can see is Assignable Tunics and Boots. The pattern you're currently using is the older one from before ShipInit existed, and those should probably all be converted to ShipInit over time. |
|
If any of that is confusing or if you need help let me know, I can help you get it converted over. |
|
It's clear, I've dealt with shipinit quite a bit already |
4dd03e9 to
324a96f
Compare
Why wait? #5416 |
324a96f to
5cf87b7
Compare
5cf87b7 to
4bcafa6
Compare
|
I'd like to request one thing before merging this, that being something leggett mentioned in another PR: more specific |
serprex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unique init func names
fc476af to
f03bc01
Compare
* Faster empty bottle, faster bean skulltula * shipinit
Reviving #4368 & #4369
Build Artifacts